* [PATCH] gpio: Add missing spin_lock_init in gpio-pch driver
@ 2012-01-17 8:40 Axel Lin
2012-01-17 9:02 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-01-17 8:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Tomoya MORINAGA, Grant Likely, Linus Walleij
This bug was introduced by commit d568a681
"gpio-pch: add spinlock in suspend/resume processing"
which adds a spinlock to struct pch_gpio but never init the spinlock.
Reported-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/gpio/gpio-pch.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index f060329..e84eabf 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -392,6 +392,7 @@ static int __devinit pch_gpio_probe(struct pci_dev *pdev,
chip->reg = chip->base;
pci_set_drvdata(pdev, chip);
mutex_init(&chip->lock);
+ spin_lock_init(&chip->spinlock);
pch_gpio_setup(chip);
ret = gpiochip_add(&chip->gpio);
if (ret) {
--
1.7.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: Add missing spin_lock_init in gpio-pch driver
2012-01-17 8:40 [PATCH] gpio: Add missing spin_lock_init in gpio-pch driver Axel Lin
@ 2012-01-17 9:02 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-01-17 9:02 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Tomoya MORINAGA, Grant Likely, Linus Walleij
On Tue, Jan 17, 2012 at 9:40 AM, Axel Lin <axel.lin@gmail.com> wrote:
> This bug was introduced by commit d568a681
> "gpio-pch: add spinlock in suspend/resume processing"
> which adds a spinlock to struct pch_gpio but never init the spinlock.
>
> Reported-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-17 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-17 8:40 [PATCH] gpio: Add missing spin_lock_init in gpio-pch driver Axel Lin
2012-01-17 9:02 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®