From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Keith Packard <keithp@keithp.com>
Subject: [PATCH 0/2] drm/i915: Use correct bpc computations for DisplayPort
Date: Wed, 25 Jan 2012 08:16:24 -0800 [thread overview]
Message-ID: <1327508186-26704-1-git-send-email-keithp@keithp.com> (raw)
Here's a couple of patches that fix some bpc (bits per component)
computation issues with DisplayPort. The problem was that the
DisplayPort code tried to figure out the 'current' bpc by looking at
the bpp stored in an associated crtc, but that was never right (as
described in the message for the first patch).
The first patch assumes that the display will run at 8bpc (24bpp) if
the link has enough bandwidth, otherwise at 6bpc (18bpp). This is
essentially what the existing code ends up doing at boot time; modes
are computed before any crtc is assigned, so intel_dp_link_required
would have used 24bpp for bandwidth computations.
The second patch allows for arbitrary bpc values, computing the
display bpc in both intel_dp_mode_fixup and the two crtc_mode_set
functions. Obviously doing the computation once would be nice, but
there isn't an obvious place to stick the result between those two
functions as the bpc computation is also needed for non-DP encoders.
This should fix problems where display port doesn't come back after
resume for panels which need 6bpc modes.
--
keith.packard@intel.com
next reply other threads:[~2012-01-25 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 16:16 Keith Packard [this message]
2012-01-25 16:16 ` [PATCH 1/2] drm/i915: Force explicit bpp selection for intel_dp_link_required Keith Packard
2012-01-25 20:51 ` [Intel-gfx] " Jesse Barnes
2012-01-25 21:17 ` Keith Packard
2012-01-25 21:50 ` Daniel Vetter
2012-01-25 22:45 ` Keith Packard
2012-01-25 21:52 ` Daniel Vetter
2012-01-27 10:30 ` Daniel Vetter
2012-02-06 12:12 ` Dave Airlie
2012-02-06 16:03 ` Daniel Vetter
2012-02-06 22:10 ` Keith Packard
2012-01-25 16:16 ` [PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate Keith Packard
2012-01-25 22:11 ` [Intel-gfx] " Daniel Vetter
2012-01-25 22:56 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327508186-26704-1-git-send-email-keithp@keithp.com \
--to=keithp@keithp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®