From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Dmitry Torokhov <dtor@mail.ru>
Cc: Misael Lopez Cruz <misael.lopez@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: [RFC 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies
Date: Thu, 2 Feb 2012 14:16:59 +0200 [thread overview]
Message-ID: <1328185019-29575-8-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1328185019-29575-1-git-send-email-peter.ujfalusi@ti.com>
twl6040 has three power supply source:
VBAT needs to be connected to VBAT
VIO, and V2V1.
Add regulator support for the VIO, V2V1 supplies.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/mfd/twl6040-core.c | 41 +++++++++++++++++++++++++++++++++++++++++
include/linux/mfd/twl6040.h | 2 ++
2 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040-core.c
index 21d6a99..04568ea 100644
--- a/drivers/mfd/twl6040-core.c
+++ b/drivers/mfd/twl6040-core.c
@@ -27,12 +27,14 @@
#include <linux/types.h>
#include <linux/slab.h>
#include <linux/kernel.h>
+#include <linux/err.h>
#include <linux/platform_device.h>
#include <linux/gpio.h>
#include <linux/delay.h>
#include <linux/i2c.h>
#include <linux/mfd/core.h>
#include <linux/mfd/twl6040.h>
+#include <linux/regulator/consumer.h>
#define VIBRACTRL_MEMBER(reg) ((reg == TWL6040_REG_VIBCTLL) ? 0 : 1)
@@ -541,6 +543,33 @@ static int __devinit twl6040_probe(struct i2c_client *client,
i2c_set_clientdata(client, twl6040);
+ twl6040->vio = regulator_get(&client->dev, "vio");
+ if (IS_ERR(twl6040->vio)) {
+ ret = PTR_ERR(twl6040->vio);
+ dev_err(&client->dev, "Failed to request VIO supply: %d\n",
+ ret);
+ goto regulator_get_err;
+ }
+ twl6040->v2v1 = regulator_get(&client->dev, "v2v1");
+ if (IS_ERR(twl6040->v2v1)) {
+ ret = PTR_ERR(twl6040->v2v1);
+ dev_err(&client->dev, "Failed to request V2V1 supply: %d\n",
+ ret);
+ regulator_put(twl6040->vio);
+ goto regulator_get_err;
+ }
+ ret = regulator_enable(twl6040->vio);
+ if (ret != 0) {
+ dev_err(&client->dev, "Failed to enable VIO: %d\n", ret);
+ goto power_err;
+ }
+ ret = regulator_enable(twl6040->v2v1);
+ if (ret != 0) {
+ dev_err(&client->dev, "Failed to enable V2V1: %d\n", ret);
+ regulator_disable(twl6040->vio);
+ goto power_err;
+ }
+
twl6040->dev = &client->dev;
twl6040->control_data = client;
twl6040->irq = client->irq;
@@ -632,6 +661,12 @@ gpio2_err:
if (gpio_is_valid(twl6040->audpwron))
gpio_free(twl6040->audpwron);
gpio1_err:
+ regulator_disable(twl6040->v2v1);
+ regulator_disable(twl6040->vio);
+power_err:
+ regulator_put(twl6040->vio);
+ regulator_put(twl6040->v2v1);
+regulator_get_err:
i2c_set_clientdata(client, NULL);
kfree(twl6040);
return ret;
@@ -652,6 +687,12 @@ static int __devexit twl6040_remove(struct i2c_client *client)
mfd_remove_devices(&client->dev);
i2c_set_clientdata(client, NULL);
+
+ regulator_disable(twl6040->v2v1);
+ regulator_disable(twl6040->vio);
+ regulator_put(twl6040->vio);
+ regulator_put(twl6040->v2v1);
+
kfree(twl6040);
return 0;
diff --git a/include/linux/mfd/twl6040.h b/include/linux/mfd/twl6040.h
index 72f530f..146de4e 100644
--- a/include/linux/mfd/twl6040.h
+++ b/include/linux/mfd/twl6040.h
@@ -201,6 +201,8 @@ struct twl6040_platform_data {
struct twl6040 {
struct i2c_client *control_data;
struct device *dev;
+ struct regulator *vio;
+ struct regulator *v2v1;
struct mutex mutex;
struct mutex io_mutex;
struct mutex irq_mutex;
--
1.7.8.4
next prev parent reply other threads:[~2012-02-02 12:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 12:16 [RFC 0/7] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-02 12:16 ` [RFC 1/7] MFD: twl-core: Detach twl6040 from the pmic mfd driver Peter Ujfalusi
2012-02-02 12:16 ` [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core Peter Ujfalusi
2012-02-02 12:48 ` Mark Brown
2012-02-02 13:01 ` Peter Ujfalusi
2012-02-02 13:27 ` Mark Brown
2012-02-02 12:16 ` [RFC 3/7] ASoC: twl6040: Remove dependency on twl4030 from Kconfig Peter Ujfalusi
2012-02-02 12:42 ` Mark Brown
2012-02-02 12:16 ` [RFC 4/7] OMAP: 4430sdp: Correct fixed regulator device ID Peter Ujfalusi
2012-02-02 12:38 ` Mark Brown
2012-02-02 12:16 ` [RFC 5/7] OMAP: sdp4430: Add fixed regulator for twl6040 needs Peter Ujfalusi
2012-02-02 12:40 ` Mark Brown
2012-02-02 13:03 ` Peter Ujfalusi
2012-02-02 12:16 ` [RFC 6/7] OMAP: omap4panda: " Peter Ujfalusi
2012-02-02 12:41 ` Mark Brown
2012-02-02 12:16 ` Peter Ujfalusi [this message]
2012-02-02 12:52 ` [RFC 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies Mark Brown
2012-02-02 13:18 ` Peter Ujfalusi
2012-02-02 13:32 ` Mark Brown
2012-02-02 13:59 ` Peter Ujfalusi
2012-02-02 14:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328185019-29575-8-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dtor@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®