mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] RE: NFSv4: truncate returns I/O error
Date: Wed,  7 Mar 2012 17:40:47 -0500	[thread overview]
Message-ID: <1331160049-3842-1-git-send-email-Trond.Myklebust@netapp.com> (raw)
In-Reply-To: <87k42yjb0c.fsf@tucsk.pomaz.szeredi.hu>

Hi Miklos,

The base cause of the test failure was that the client was holding
onto a read delegation while trying to truncate the file. Whereas
some servers allow the client to do this (provided that nobody else
holds a read delegation), the Linux server does not, and returns
an error.
The fix is therefore to return the delegation if the server rejects
our attempt (see patch 2/2).

I've included patch 1/2 since it too was already queued for the
stable@vger.kernel.org queue, and so 2/2 has a dependency...

Thanks for the bug report!

Cheers
 Trond

Trond Myklebust (2):
  NFS: Properly handle the case where the delegation is revoked
  NFSv4: Return the delegation if the server returns NFS4ERR_OPENMODE

 fs/nfs/delegation.c |   11 +++++++++++
 fs/nfs/delegation.h |    1 +
 fs/nfs/nfs4_fs.h    |    3 +++
 fs/nfs/nfs4proc.c   |   31 ++++++++++++++++++++++++++++---
 fs/nfs/nfs4state.c  |   29 +++++++++++++++++++++++++++--
 5 files changed, 70 insertions(+), 5 deletions(-)

-- 
1.7.7.6


  parent reply	other threads:[~2012-03-07 22:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 10:10 Miklos Szeredi
2012-03-06 14:16 ` Myklebust, Trond
2012-03-07 22:40 ` Trond Myklebust [this message]
2012-03-07 22:40   ` [PATCH 1/2] NFS: Properly handle the case where the delegation is revoked Trond Myklebust
2012-03-07 22:40     ` [PATCH 2/2] NFSv4: Return the delegation if the server returns NFS4ERR_OPENMODE Trond Myklebust
2012-03-08 17:52       ` Olga Kornievskaia
2012-03-08 18:15         ` Myklebust, Trond
2012-03-08 20:23           ` Olga Kornievskaia
2012-03-08 20:42             ` J. Bruce Fields
2012-03-08 20:50               ` Myklebust, Trond
2012-03-08 20:57                 ` J. Bruce Fields
2012-03-08 21:02                   ` Myklebust, Trond
2012-03-08 21:09                     ` J. Bruce Fields
2012-03-08 21:12                   ` Boaz Harrosh
2012-03-08 21:27                 ` Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331160049-3842-1-git-send-email-Trond.Myklebust@netapp.com \
    --to=trond.myklebust@netapp.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®