From: Steven Rostedt <rostedt@goodmis.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@amd64.org>, Kees Cook <keescook@chromium.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Andy Lutomirski <luto@mit.edu>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Frysinger <vapier@gentoo.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: use enum instead of literals for trap values
Date: Fri, 09 Mar 2012 15:21:58 -0500 [thread overview]
Message-ID: <1331324518.25686.606.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4F5A644C.3080306@zytor.com>
On Fri, 2012-03-09 at 12:13 -0800, H. Peter Anvin wrote:
> On 03/09/2012 11:08 AM, Borislav Petkov wrote:
> >
> > So is this reserved or are we using it for Spurious IRQs? If we use it,
> > then 'RES' is a bad name. Maybe we define our own like
> >
> > X86_VEC_SP
> >
> > and then do
> >
> > X86_VEC_IR for IRET
> >
> > in the manner we assumed for the rest?
> >
>
> Actually I prefer if we didn't use two-letter versions for the ones that
> aren't defined in the documentation; especially IRET which is a pure
> Linux invention.
>
I agree with this. The two-letter abbreviations are good if they come
from the official documentation. This makes it easy to reference.
For the Linux made up ones, a more descriptive name is better. Then
there wont be confusion when people look at "IR" and can't find it
online or in the document, and scratch their head thinking they are not
smart enough to do kernel development and we lose another kernel
developer ;-)
-- Steve
next prev parent reply other threads:[~2012-03-09 20:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 7:42 Kees Cook
2012-03-09 9:28 ` Ingo Molnar
2012-03-09 16:30 ` Kees Cook
2012-03-09 17:57 ` H. Peter Anvin
2012-03-09 18:21 ` Kees Cook
2012-03-09 18:28 ` Borislav Petkov
2012-03-09 18:52 ` Steven Rostedt
2012-03-09 20:10 ` H. Peter Anvin
2012-03-09 22:13 ` Ingo Molnar
2012-03-09 22:23 ` H. Peter Anvin
2012-03-10 8:34 ` Pekka Enberg
2012-03-09 18:54 ` Kees Cook
2012-03-09 19:08 ` Borislav Petkov
2012-03-09 19:14 ` Steven Rostedt
2012-03-09 19:58 ` Kees Cook
2012-03-09 20:13 ` H. Peter Anvin
2012-03-09 20:21 ` Steven Rostedt [this message]
2012-03-10 10:15 ` Borislav Petkov
2012-03-10 13:54 ` Steven Rostedt
2012-03-10 14:27 ` Borislav Petkov
2012-03-11 7:52 ` Alexey Dobriyan
2013-01-22 22:44 [PATCH] x86: Use " John Kacur
2013-02-01 17:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331324518.25686.606.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®