From: Ben Hutchings <ben@decadent.org.uk>
To: John Kacur <jkacur@redhat.com>
Cc: stable@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Clark Williams <williams@redhat.com>,
rt-users <linux-rt-users@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Use enum instead of literals for trap values
Date: Fri, 01 Feb 2013 18:18:36 +0100 [thread overview]
Message-ID: <1359739116.31386.64.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <1358894672-10914-1-git-send-email-jkacur@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2254 bytes --]
On Tue, 2013-01-22 at 23:44 +0100, John Kacur wrote:
> From: Kees Cook <keescook@chromium.org>
>
> commit c94082656dac74257f63e91f78d5d458ac781fa5 upstream
>
> The traps are referred to by their numbers and it can be difficult to
> understand them while reading the code without context. This patch adds
> enumeration of the trap numbers and replaces the numbers with the correct
> enum for x86.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Link: http://lkml.kernel.org/r/20120310000710.GA32667@www.outflux.net
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> Cherry-picked-for: v2.3.37
>
> This fixes the following build error
> make O=/bld/v3.2.37
> make[2]: Nothing to be done for `relocs'.
> Using /home/jkacur/linux-rt as source for kernel
> GEN /bld/v3.2.37/Makefile
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL /home/jkacur/linux-rt/scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CHK kernel/config_data.h
> CC [M] drivers/misc/sgi-xp/xpc_main.o
> /home/jkacur/linux-rt/drivers/misc/sgi-xp/xpc_main.c: In function ‘xpc_system_die’:
> /home/jkacur/linux-rt/drivers/misc/sgi-xp/xpc_main.c:1208: error: ‘X86_TRAP_DF’ undeclared (first use in this function)
> /home/jkacur/linux-rt/drivers/misc/sgi-xp/xpc_main.c:1208: error: (Each undeclared identifier is reported only once
> /home/jkacur/linux-rt/drivers/misc/sgi-xp/xpc_main.c:1208: error: for each function it appears in.)
> /home/jkacur/linux-rt/drivers/misc/sgi-xp/xpc_main.c:1211: error: ‘X86_TRAP_MF’ undeclared (first use in this function)
> /home/jkacur/linux-rt/drivers/misc/sgi-xp/xpc_main.c:1212: error: ‘X86_TRAP_XF’ undeclared (first use in this function)
> make[4]: *** [drivers/misc/sgi-xp/xpc_main.o] Error 1
> make[3]: *** [drivers/misc/sgi-xp] Error 2
> make[2]: *** [drivers/misc] Error 2
> make[1]: *** [drivers] Error 2
> make: *** [sub-make] Error 2
[...]
Queued up for 3.2, thanks. I've also added X86_UV and SGI_XP to the
x86 .config I build.
Ben.
--
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
- Albert Einstein
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-02-01 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 22:44 John Kacur
2013-02-01 17:18 ` Ben Hutchings [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-09 7:42 [PATCH] x86: use " Kees Cook
2012-03-09 9:28 ` Ingo Molnar
2012-03-09 16:30 ` Kees Cook
2012-03-09 17:57 ` H. Peter Anvin
2012-03-09 18:21 ` Kees Cook
2012-03-09 18:28 ` Borislav Petkov
2012-03-09 18:52 ` Steven Rostedt
2012-03-09 20:10 ` H. Peter Anvin
2012-03-09 22:13 ` Ingo Molnar
2012-03-09 22:23 ` H. Peter Anvin
2012-03-10 8:34 ` Pekka Enberg
2012-03-09 18:54 ` Kees Cook
2012-03-09 19:08 ` Borislav Petkov
2012-03-09 19:14 ` Steven Rostedt
2012-03-09 19:58 ` Kees Cook
2012-03-09 20:13 ` H. Peter Anvin
2012-03-09 20:21 ` Steven Rostedt
2012-03-10 10:15 ` Borislav Petkov
2012-03-10 13:54 ` Steven Rostedt
2012-03-10 14:27 ` Borislav Petkov
2012-03-11 7:52 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359739116.31386.64.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®