From: Steven Rostedt <rostedt@goodmis.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: recent x86-64 nested NMI adjustments
Date: Mon, 12 Mar 2012 10:21:11 -0400 [thread overview]
Message-ID: <1331562071.25686.635.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4F5E08C30200007800077ACC@nat28.tlf.novell.com>
On Mon, 2012-03-12 at 13:31 +0000, Jan Beulich wrote:
> Ah, right - the way the new check got placed I (wrongly) implied
> it to guard the immediately succeeding check of the "special
> variable", whereas it really guards (only) test_in_nmi.
The reason I placed it there was because I thought that would be the
more common case. As nested NMIs are the .00001% case, and the variable
check only can prove that we were in a nested NMI, but does not prove we
are not, in which case it would still need to do the other checks.
I figured that a good % of NMIs will interrupt userspace, and let that
be the fast path. When an NMI interrupts userspace, this check will make
it skip the rest of the checks. Seemed to be the logical placement.
But I see where the confusion came from. The placement was for
optimization of the fast path, not for where it *had* to be.
>
> Thanks for the explanation, and sorry for the noise then.
No prob,
-- Steve
prev parent reply other threads:[~2012-03-12 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 12:10 Jan Beulich
2012-03-12 13:16 ` Steven Rostedt
2012-03-12 13:31 ` Jan Beulich
2012-03-12 14:21 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331562071.25686.635.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®