From: "Jan Beulich" <JBeulich@suse.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: <mingo@elte.hu>, "Peter Zijlstra" <peterz@infradead.org>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: recent x86-64 nested NMI adjustments
Date: Mon, 12 Mar 2012 12:10:27 +0000 [thread overview]
Message-ID: <4F5DF5C30200007800077A5B@nat28.tlf.novell.com> (raw)
Hi Steven,
the explanation of 45d5a1683c04be28abdf5c04c27b1417e0374486
seems bogus to me: When arriving from user mode, %rsp won't point
to the user stack anymore, as it gets switched away from during the
processing of the exception (the more that the IDT entry specifies a
separate stack anyway, which even guarantees this for kernel mode
entries).
Further, a38449ef596b345e13a8f9b7d5cd9fedb8fcf921 makes the
(presumably superfluous) compare a 4-byte one, while the
documentation isn't really stating that selectors get pushed zero-
extended. Hence, if not reverting the first change altogether, I'd
minimally recommend converting the compare to a 2-byte one.
Jan
next reply other threads:[~2012-03-12 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 12:10 Jan Beulich [this message]
2012-03-12 13:16 ` Steven Rostedt
2012-03-12 13:31 ` Jan Beulich
2012-03-12 14:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5DF5C30200007800077A5B@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®