* [PATCH] vfs: Fix dup_mnt_ns
@ 2012-03-15 0:41 Sasha Levin
0 siblings, 0 replies; only message in thread
From: Sasha Levin @ 2012-03-15 0:41 UTC (permalink / raw)
To: viro, akpm, ak; +Cc: linux-fsdevel, linux-kernel, davej, rusty, Sasha Levin
Commit f8b88187 ("brlocks/lglocks: cleanups") has accidently dropped the
assignment of the new root into the mnt_fs.
This leads to NULL dereferences since ->root is assumed to be always non-NULL.
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
fs/namespace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index 5a6208b..224aff1 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2250,6 +2250,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns,
kfree(new_ns);
return ERR_PTR(-ENOMEM);
}
+ new_ns->root = new;
br_write_lock(&vfsmount_lock);
list_add_tail(&new_ns->list, &new->mnt_list);
br_write_unlock(&vfsmount_lock);
--
1.7.8.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-03-14 22:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-15 0:41 [PATCH] vfs: Fix dup_mnt_ns Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®