* [PATCH-rt] Revert "kprobes: adjust "fix a memory leak in function pre_handler_kretprobe()""
@ 2012-03-15 17:00 John Kacur
0 siblings, 0 replies; only message in thread
From: John Kacur @ 2012-03-15 17:00 UTC (permalink / raw)
To: rt-users, Steven Rostedt; +Cc: Thomas Gleixner, lkml, John Kacur
This reverts commit b8a0040ef7112439ad2efac6f1a79aa842b5924f.
Because rt pulls in 7b8d0e5, the above fix which comes from v3.0.24
should not be applied. kretprobe is a raw_spinlock_t for real-time.
Before the revert we get the following compile errors
kernel/kprobes.c:1664: warning: passing argument 1 of ‘rt_spin_lock’ from incompatible pointer type
kernel/kprobes.c:1666: warning: passing argument 1 of ‘rt_spin_unlock’ from incompatible pointer type
Note: This patch is for v3.0.24-rt42-rc1
Signed-off-by: John Kacur <jkacur@redhat.com>
---
kernel/kprobes.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index a7dcf06..9cdbf26 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1661,9 +1661,9 @@ static int __kprobes pre_handler_kretprobe(struct kprobe *p,
ri->task = current;
if (rp->entry_handler && rp->entry_handler(ri, regs)) {
- spin_lock_irqsave(&rp->lock, flags);
+ raw_spin_lock_irqsave(&rp->lock, flags);
hlist_add_head(&ri->hlist, &rp->free_instances);
- spin_unlock_irqrestore(&rp->lock, flags);
+ raw_spin_unlock_irqrestore(&rp->lock, flags);
return 0;
}
--
1.7.2.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-03-15 17:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-15 17:00 [PATCH-rt] Revert "kprobes: adjust "fix a memory leak in function pre_handler_kretprobe()"" John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®