mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [RESEND PATCH] mtd: fix section mismatch for doc_probe_device
@ 2012-03-15 10:19 Ryosuke Saito
  2012-03-16 11:51 ` Artem Bityutskiy
  2012-03-16 12:34 ` Artem Bityutskiy
  0 siblings, 2 replies; 3+ messages in thread
From: Ryosuke Saito @ 2012-03-15 10:19 UTC (permalink / raw)
  To: dwmw2
  Cc: robert.jarzmik, mikedunn, ivan.djelic, artem.bityutskiy,
	linux-mtd, linux-kernel

doc_probe_device() is only called from docg3_probe() which is in .init.text,
so it must be in the same section to avoid a section mismatch warning.

Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>
---
 drivers/mtd/devices/docg3.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 25f688c..db9a4b7 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1846,8 +1846,8 @@ static void __init doc_set_driver_info(int
chip_id, struct mtd_info *mtd)
  * if a memory allocation failed. If floor 0 is checked, a reset of the ASIC is
  * launched.
  */
-static struct mtd_info *doc_probe_device(void __iomem *base, int floor,
-					 struct device *dev)
+static struct mtd_info * __init
+doc_probe_device(void __iomem *base, int floor, struct device *dev)
 {
 	int ret, bbt_nbpages;
 	u16 chip_id, chip_id_inv;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND PATCH] mtd: fix section mismatch for doc_probe_device
  2012-03-15 10:19 [RESEND PATCH] mtd: fix section mismatch for doc_probe_device Ryosuke Saito
@ 2012-03-16 11:51 ` Artem Bityutskiy
  2012-03-16 12:34 ` Artem Bityutskiy
  1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2012-03-16 11:51 UTC (permalink / raw)
  To: Ryosuke Saito
  Cc: dwmw2, robert.jarzmik, mikedunn, ivan.djelic, linux-mtd, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

On Thu, 2012-03-15 at 19:19 +0900, Ryosuke Saito wrote:
> doc_probe_device() is only called from docg3_probe() which is in .init.text,
> so it must be in the same section to avoid a section mismatch warning.
> 
> Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>
> ---
>  drivers/mtd/devices/docg3.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 25f688c..db9a4b7 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1846,8 +1846,8 @@ static void __init doc_set_driver_info(int
> chip_id, struct mtd_info *mtd)

The patch is line-wrapped and not applicable with git am :-(

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND PATCH] mtd: fix section mismatch for doc_probe_device
  2012-03-15 10:19 [RESEND PATCH] mtd: fix section mismatch for doc_probe_device Ryosuke Saito
  2012-03-16 11:51 ` Artem Bityutskiy
@ 2012-03-16 12:34 ` Artem Bityutskiy
  1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2012-03-16 12:34 UTC (permalink / raw)
  To: Ryosuke Saito
  Cc: dwmw2, robert.jarzmik, mikedunn, ivan.djelic, linux-mtd, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

On Thu, 2012-03-15 at 19:19 +0900, Ryosuke Saito wrote:
> doc_probe_device() is only called from docg3_probe() which is in .init.text,
> so it must be in the same section to avoid a section mismatch warning.
> 
> Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>

I've fixed up your patch and push to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-16 12:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-15 10:19 [RESEND PATCH] mtd: fix section mismatch for doc_probe_device Ryosuke Saito
2012-03-16 11:51 ` Artem Bityutskiy
2012-03-16 12:34 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®