mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mfd: Remove unused mutex from struct tps65090
@ 2012-03-22  9:14 Axel Lin
  2012-03-22  9:16 ` Venu Byravarasu
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-03-22  9:14 UTC (permalink / raw)
  To: linux-kernel; +Cc: Venu Byravarasu, Samuel Ortiz

The mutex lock is not used after converting to use regmap, remove it.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/mfd/tps65090.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
index a66d4df..9a84bda 100644
--- a/drivers/mfd/tps65090.c
+++ b/drivers/mfd/tps65090.c
@@ -79,7 +79,6 @@ static struct mfd_cell tps65090s[] = {
 };
 
 struct tps65090 {
-	struct mutex		lock;
 	struct device		*dev;
 	struct i2c_client	*client;
 	struct regmap		*rmap;
@@ -283,8 +282,6 @@ static int __devinit tps65090_i2c_probe(struct i2c_client *client,
 	tps65090->dev = &client->dev;
 	i2c_set_clientdata(client, tps65090);
 
-	mutex_init(&tps65090->lock);
-
 	if (client->irq) {
 		ret = tps65090_irq_init(tps65090, client->irq, pdata->irq_base);
 		if (ret) {
-- 
1.7.5.4




^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] mfd: Remove unused mutex from struct tps65090
  2012-03-22  9:14 [PATCH] mfd: Remove unused mutex from struct tps65090 Axel Lin
@ 2012-03-22  9:16 ` Venu Byravarasu
  0 siblings, 0 replies; 2+ messages in thread
From: Venu Byravarasu @ 2012-03-22  9:16 UTC (permalink / raw)
  To: Axel Lin, linux-kernel; +Cc: Samuel Ortiz

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1397 bytes --]

Looks good to me.
Acked-by: Venu Byravarasu <vbyravarasu@nvidia.com>

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@gmail.com]
> Sent: Thursday, March 22, 2012 2:44 PM
> To: linux-kernel@vger.kernel.org
> Cc: Venu Byravarasu; Samuel Ortiz
> Subject: [PATCH] mfd: Remove unused mutex from struct tps65090
> 
> The mutex lock is not used after converting to use regmap, remove it.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/mfd/tps65090.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index a66d4df..9a84bda 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -79,7 +79,6 @@ static struct mfd_cell tps65090s[] = {
>  };
> 
>  struct tps65090 {
> -	struct mutex		lock;
>  	struct device		*dev;
>  	struct i2c_client	*client;
>  	struct regmap		*rmap;
> @@ -283,8 +282,6 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  	tps65090->dev = &client->dev;
>  	i2c_set_clientdata(client, tps65090);
> 
> -	mutex_init(&tps65090->lock);
> -
>  	if (client->irq) {
>  		ret = tps65090_irq_init(tps65090, client->irq, pdata-
> >irq_base);
>  		if (ret) {
> --
> 1.7.5.4
> 
> 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-22  9:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-22  9:14 [PATCH] mfd: Remove unused mutex from struct tps65090 Axel Lin
2012-03-22  9:16 ` Venu Byravarasu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®