mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>,
	apw@canonical.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] checkpatch.pl: thou shalt not use () or (...) in function declarations
Date: Thu, 22 Mar 2012 09:33:33 -0700	[thread overview]
Message-ID: <1332434013.1946.10.camel@joe2Laptop> (raw)
In-Reply-To: <CAFLxGvyaz7SgV1BaLdC5uKMq_LTgFDHCiO+YReKdE4h7Ebi59A@mail.gmail.com>

On Thu, 2012-03-22 at 16:49 +0100, richard -rw- weinberger wrote:
> On Thu, Mar 22, 2012 at 4:27 PM, Phil Carmody
> <ext-phil.2.carmody@nokia.com> wrote:
> > After HPA's wonderful lkml post, referenced, it seems worth trying to
> > detect this robomatically.
> 
> See:
> http://marc.info/?l=linux-kernel&m=133193918813599

But Phil's test is better because it also
tests for function declarations on multiple
lines like

type
foo(...)

		if ($ctx =~ /((\b$Type\s+$Ident)\s*\(\s*(?:\.\.\.)?\s*\))/) {

The ERROR needs updating for a --ignore type though.
Something like this may be better.

		ERROR("FUNCTION_NO_PROTOTYPE",
		      "Bad function definition - $1 should probably be $2(void)\n" .
		      herecurr);

And I think the screed funny once but not useful.



  reply	other threads:[~2012-03-22 16:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 15:27 Phil Carmody
2012-03-22 15:49 ` richard -rw- weinberger
2012-03-22 16:33   ` Joe Perches [this message]
2012-03-22 16:22 ` Jiri Slaby
2012-03-22 16:49   ` Valdis.Kletnieks
2012-03-22 16:55     ` Jiri Slaby
2012-03-22 17:00       ` Jiri Slaby
2012-03-22 17:17       ` Valdis.Kletnieks
2012-03-22 19:00         ` Joe Perches
2012-03-22 16:53   ` H. Peter Anvin
2012-03-22 16:56     ` Jiri Slaby
2012-03-22 17:48     ` Phil Carmody
2012-03-22 19:10       ` Peter Seebach
2012-03-22 20:01         ` Phil Carmody
2012-03-22 17:17   ` Nick Bowler
2012-03-22 17:19     ` Nick Bowler
2012-03-26 10:03     ` Pedro Alves
2012-04-16  6:11       ` H. Peter Anvin
2012-03-22 17:32   ` Phil Carmody
2012-04-15 18:18   ` Phil Carmody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332434013.1946.10.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®