From: Joe Perches <joe@perches.com>
To: Valdis.Kletnieks@vt.edu
Cc: Jiri Slaby <jslaby@suse.cz>,
Phil Carmody <ext-phil.2.carmody@nokia.com>,
apw@canonical.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] checkpatch.pl: thou shalt not use () or (...) in function declarations
Date: Thu, 22 Mar 2012 12:00:28 -0700 [thread overview]
Message-ID: <1332442828.5636.39.camel@joe2Laptop> (raw)
In-Reply-To: <6258.1332436627@turing-police.cc.vt.edu>
On Thu, 2012-03-22 at 13:17 -0400, Valdis.Kletnieks@vt.edu wrote:
> Those can be 'int foo(void)' can't they? The other historical usage is for
> 'int foo()' to denote an old K&R-style varargs list, which is like disco - a
> bad idea from long agon that's never coming back. ;)
>
> Of course, if we add this to checkpatch, we'll have a flood of fixup patches.
Not really, more like a mist than a flood.
There just aren't many in-kernel uses.
There are 10 in drivers/, 15 in arch/, none in include/
$ grep -rP --include=*.[ch] "^\w+\s+\w+\s*\(\s*(?:\.\.\.){0,1}\s*\)" *
A single trivial patch should work for all of them.
> Maybe we just need to say "3.5 will be the int foo() housecleaning release" and
> be done with it?
Sensible.
next prev parent reply other threads:[~2012-03-22 19:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 15:27 Phil Carmody
2012-03-22 15:49 ` richard -rw- weinberger
2012-03-22 16:33 ` Joe Perches
2012-03-22 16:22 ` Jiri Slaby
2012-03-22 16:49 ` Valdis.Kletnieks
2012-03-22 16:55 ` Jiri Slaby
2012-03-22 17:00 ` Jiri Slaby
2012-03-22 17:17 ` Valdis.Kletnieks
2012-03-22 19:00 ` Joe Perches [this message]
2012-03-22 16:53 ` H. Peter Anvin
2012-03-22 16:56 ` Jiri Slaby
2012-03-22 17:48 ` Phil Carmody
2012-03-22 19:10 ` Peter Seebach
2012-03-22 20:01 ` Phil Carmody
2012-03-22 17:17 ` Nick Bowler
2012-03-22 17:19 ` Nick Bowler
2012-03-26 10:03 ` Pedro Alves
2012-04-16 6:11 ` H. Peter Anvin
2012-03-22 17:32 ` Phil Carmody
2012-04-15 18:18 ` Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332442828.5636.39.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=apw@canonical.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®