mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eldad Zack <eldad@fogrefinery.com>
To: "David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eldad Zack <eldad@fogrefinery.com>
Subject: [PATCH 3/8] net/ipv6/datagram.c: Checkpatch cleanups
Date: Sun,  1 Apr 2012 19:49:03 +0200	[thread overview]
Message-ID: <1333302548-9187-3-git-send-email-eldad@fogrefinery.com> (raw)
In-Reply-To: <1333302548-9187-1-git-send-email-eldad@fogrefinery.com>

datagram.c:101: ERROR: "(foo*)" should be "(foo *)"
datagram.c:521: ERROR: space required before the open parenthesis '('
datagram.c:830: WARNING: braces {} are not necessary for single statement blocks
datagram.c:849: WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
 net/ipv6/datagram.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c
index 76832c8..f6210d6 100644
--- a/net/ipv6/datagram.c
+++ b/net/ipv6/datagram.c
@@ -98,7 +98,7 @@ int ip6_datagram_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len)
 		sin.sin_port = usin->sin6_port;
 
 		err = ip4_datagram_connect(sk,
-					   (struct sockaddr*) &sin,
+					   (struct sockaddr *) &sin,
 					   sizeof(sin));
 
 ipv4_connected:
@@ -518,7 +518,7 @@ int datagram_recv_ctl(struct sock *sk, struct msghdr *msg, struct sk_buff *skb)
 			unsigned len;
 			u8 *ptr = nh + off;
 
-			switch(nexthdr) {
+			switch (nexthdr) {
 			case IPPROTO_DSTOPTS:
 				nexthdr = ptr[0];
 				len = (ptr[1] + 1) << 3;
@@ -827,9 +827,8 @@ int datagram_send_ctl(struct net *net, struct sock *sk,
 			int tc;
 
 			err = -EINVAL;
-			if (cmsg->cmsg_len != CMSG_LEN(sizeof(int))) {
+			if (cmsg->cmsg_len != CMSG_LEN(sizeof(int)))
 				goto exit_f;
-			}
 
 			tc = *(int *)CMSG_DATA(cmsg);
 			if (tc < -1 || tc > 0xff)
@@ -846,9 +845,8 @@ int datagram_send_ctl(struct net *net, struct sock *sk,
 			int df;
 
 			err = -EINVAL;
-			if (cmsg->cmsg_len != CMSG_LEN(sizeof(int))) {
+			if (cmsg->cmsg_len != CMSG_LEN(sizeof(int)))
 				goto exit_f;
-			}
 
 			df = *(int *)CMSG_DATA(cmsg);
 			if (df < 0 || df > 1)
-- 
1.7.9.5


  parent reply	other threads:[~2012-04-01 17:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01 17:49 [PATCH 1/8] net/ipv6/sit.c: Checkpatch cleanup Eldad Zack
2012-04-01 17:49 ` [PATCH 2/8] net/ipv6/addrconf_core.c: " Eldad Zack
2012-04-02  3:07   ` David Miller
2012-04-01 17:49 ` Eldad Zack [this message]
2012-04-02  3:07   ` [PATCH 3/8] net/ipv6/datagram.c: Checkpatch cleanups David Miller
2012-04-01 17:49 ` [PATCH 4/8] net/ipv6/exthdrs.c: " Eldad Zack
2012-04-02  3:07   ` David Miller
2012-04-01 17:49 ` [PATCH 5/8] net/ipv6/exthdrs_core.c: " Eldad Zack
2012-04-02  3:07   ` David Miller
2012-04-01 17:49 ` [PATCH 6/8] net/ipv6/fib6_rules.c: Checkpatch cleanup Eldad Zack
2012-04-02  3:07   ` David Miller
2012-04-01 17:49 ` [PATCH 7/8] net/ipv6/icmp.c: Checkpatch cleanups Eldad Zack
2012-04-02  3:07   ` David Miller
2012-04-01 17:49 ` [PATCH 8/8] net/ipv6/addrconf.c: " Eldad Zack
2012-04-02  3:07   ` David Miller
2012-04-02  3:07 ` [PATCH 1/8] net/ipv6/sit.c: Checkpatch cleanup David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333302548-9187-3-git-send-email-eldad@fogrefinery.com \
    --to=eldad@fogrefinery.com \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome