From: Eldad Zack <eldad@fogrefinery.com>
To: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Eldad Zack <eldad@fogrefinery.com>
Subject: [PATCH 7/8] net/ipv6/icmp.c: Checkpatch cleanups
Date: Sun, 1 Apr 2012 19:49:07 +0200 [thread overview]
Message-ID: <1333302548-9187-7-git-send-email-eldad@fogrefinery.com> (raw)
In-Reply-To: <1333302548-9187-1-git-send-email-eldad@fogrefinery.com>
icmp.c:501: ERROR: "(foo*)" should be "(foo *)"
icmp.c:582: ERROR: "(foo*)" should be "(foo *)"
icmp.c:954: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
net/ipv6/icmp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index 27ac95a..cc079d8 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -498,7 +498,7 @@ void icmpv6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info)
err = ip6_append_data(sk, icmpv6_getfrag, &msg,
len + sizeof(struct icmp6hdr),
sizeof(struct icmp6hdr), hlimit,
- np->tclass, NULL, &fl6, (struct rt6_info*)dst,
+ np->tclass, NULL, &fl6, (struct rt6_info *)dst,
MSG_DONTWAIT, np->dontfrag);
if (err) {
ICMP6_INC_STATS_BH(net, idev, ICMP6_MIB_OUTERRORS);
@@ -579,7 +579,7 @@ static void icmpv6_echo_reply(struct sk_buff *skb)
err = ip6_append_data(sk, icmpv6_getfrag, &msg, skb->len + sizeof(struct icmp6hdr),
sizeof(struct icmp6hdr), hlimit, np->tclass, NULL, &fl6,
- (struct rt6_info*)dst, MSG_DONTWAIT,
+ (struct rt6_info *)dst, MSG_DONTWAIT,
np->dontfrag);
if (err) {
@@ -950,7 +950,6 @@ int icmpv6_err_convert(u8 type, u8 code, int *err)
return fatal;
}
-
EXPORT_SYMBOL(icmpv6_err_convert);
#ifdef CONFIG_SYSCTL
--
1.7.9.5
next prev parent reply other threads:[~2012-04-01 17:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 17:49 [PATCH 1/8] net/ipv6/sit.c: Checkpatch cleanup Eldad Zack
2012-04-01 17:49 ` [PATCH 2/8] net/ipv6/addrconf_core.c: " Eldad Zack
2012-04-02 3:07 ` David Miller
2012-04-01 17:49 ` [PATCH 3/8] net/ipv6/datagram.c: Checkpatch cleanups Eldad Zack
2012-04-02 3:07 ` David Miller
2012-04-01 17:49 ` [PATCH 4/8] net/ipv6/exthdrs.c: " Eldad Zack
2012-04-02 3:07 ` David Miller
2012-04-01 17:49 ` [PATCH 5/8] net/ipv6/exthdrs_core.c: " Eldad Zack
2012-04-02 3:07 ` David Miller
2012-04-01 17:49 ` [PATCH 6/8] net/ipv6/fib6_rules.c: Checkpatch cleanup Eldad Zack
2012-04-02 3:07 ` David Miller
2012-04-01 17:49 ` Eldad Zack [this message]
2012-04-02 3:07 ` [PATCH 7/8] net/ipv6/icmp.c: Checkpatch cleanups David Miller
2012-04-01 17:49 ` [PATCH 8/8] net/ipv6/addrconf.c: " Eldad Zack
2012-04-02 3:07 ` David Miller
2012-04-02 3:07 ` [PATCH 1/8] net/ipv6/sit.c: Checkpatch cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333302548-9187-7-git-send-email-eldad@fogrefinery.com \
--to=eldad@fogrefinery.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome