mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* scsi/ufs: likely || misuse
@ 2012-04-04 23:46 Joe Perches
  2012-04-06  9:06 ` Santosh Y
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2012-04-04 23:46 UTC (permalink / raw)
  To: Santosh Yaraganavi, Andrew Morton; +Cc: James E.J. Bottomley, linux-kernel

Probably this should be && not ||

drivers/scsi/ufs/ufshcd.c:		if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL ||
		    task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: scsi/ufs: likely || misuse
  2012-04-04 23:46 scsi/ufs: likely || misuse Joe Perches
@ 2012-04-06  9:06 ` Santosh Y
  0 siblings, 0 replies; 2+ messages in thread
From: Santosh Y @ 2012-04-06  9:06 UTC (permalink / raw)
  To: Joe Perches; +Cc: Andrew Morton, James E.J. Bottomley, linux-kernel

On Thu, Apr 5, 2012 at 5:16 AM, Joe Perches <joe@perches.com> wrote:
> Probably this should be && not ||
>
> drivers/scsi/ufs/ufshcd.c:              if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL ||
>                    task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED)
>

Somehow missed this email. Thanks Joe. I see Venkatraman has posted a
patch with the changes.

-- 
~Santosh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-06  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-04 23:46 scsi/ufs: likely || misuse Joe Perches
2012-04-06  9:06 ` Santosh Y

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®