* [PATCH] mfd: wm8994: Cache chip revision
@ 2012-04-05 14:16 Mark Brown
2012-04-16 15:39 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-04-05 14:16 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: patches, linux-kernel, Mark Brown
There's no need to mark the chip revision registers as volatile, it won't
change at runtime so we can cache it from the device at startup.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm8994-regmap.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
index bfd25af..52e9e29 100644
--- a/drivers/mfd/wm8994-regmap.c
+++ b/drivers/mfd/wm8994-regmap.c
@@ -1122,7 +1122,6 @@ static bool wm8994_volatile_register(struct device *dev, unsigned int reg)
case WM8994_RATE_STATUS:
case WM8958_MIC_DETECT_3:
case WM8994_DC_SERVO_4E:
- case WM8994_CHIP_REVISION:
case WM8994_INTERRUPT_STATUS_1:
case WM8994_INTERRUPT_STATUS_2:
return true;
--
1.7.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: wm8994: Cache chip revision
2012-04-05 14:16 [PATCH] mfd: wm8994: Cache chip revision Mark Brown
@ 2012-04-16 15:39 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-04-16 15:39 UTC (permalink / raw)
To: Mark Brown; +Cc: patches, linux-kernel
Hi Mark,
On Thu, Apr 05, 2012 at 03:16:56PM +0100, Mark Brown wrote:
> There's no need to mark the chip revision registers as volatile, it won't
> change at runtime so we can cache it from the device at startup.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm8994-regmap.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Applied to my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-16 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-05 14:16 [PATCH] mfd: wm8994: Cache chip revision Mark Brown
2012-04-16 15:39 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®