mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Olof Johansson <olof@lixom.net>
Subject: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN
Date: Fri,  6 Apr 2012 22:40:07 -0700	[thread overview]
Message-ID: <1333777207-4151-1-git-send-email-olof@lixom.net> (raw)

This seems to have been broken since 2010, so obviously noone actually
cares about the driver:

make[4]: *** [drivers/input/touchscreen/eeti_ts.o] Error 1
drivers/input/touchscreen/eeti_ts.c: In function 'eeti_ts_irq_active':
drivers/input/touchscreen/eeti_ts.c:65:2: error: implicit declaration of function 'irq_to_gpio' [-Werror=implicit-function-declaration]

irq_to_gpio isn't available on most platforms today, so the driver
will need some rework by someone who has hardware access and can test
(to make sure that, for example, switching to level interrupts and just
keep taking them while there's more to process works).

I guess it could just be scheduled for removal, but let's start with
marking it CONFIG_BROKEN.

Signed-off-by: Olof Johansson <olof@lixom.net>
---
 drivers/input/touchscreen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 2a21419..b8f153e 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -213,7 +213,7 @@ config TOUCHSCREEN_HAMPSHIRE
 
 config TOUCHSCREEN_EETI
 	tristate "EETI touchscreen panel support"
-	depends on I2C
+	depends on I2C && BROKEN
 	help
 	  Say Y here to enable support for I2C connected EETI touch panels.
 
-- 
1.7.9.2.359.gebfc2


             reply	other threads:[~2012-04-07  5:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07  5:40 Olof Johansson [this message]
2012-04-07  7:02 ` Dmitry Torokhov
2012-04-07 18:38   ` Sven Neumann
2012-04-07 20:32     ` Olof Johansson
2012-04-07 21:04       ` Joachim Eastwood
2012-04-09  2:28       ` Haojian Zhuang
2012-04-10 10:10       ` Russell King - ARM Linux
2012-04-10 16:01         ` Dmitry Torokhov
2012-05-03  4:36     ` Dmitry Torokhov
2012-07-13  7:01       ` Dmitry Torokhov
2012-07-15 18:21         ` Daniel Mack
2012-07-17 12:59         ` Daniel Mack
2012-07-19 15:36           ` Daniel Mack
2012-07-23 16:51             ` Dmitry Torokhov
2012-07-23 17:58               ` Daniel Mack
2012-07-24 18:01               ` Emulating level IRQs (was: Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN) Daniel Mack
2012-07-24 18:58                 ` Mark Brown
2012-08-05 16:22                 ` Emulating level IRQs Daniel Mack
2012-08-05 16:56                   ` Haojian Zhuang
2012-08-05 17:56                     ` Daniel Mack
2012-08-06  1:45                       ` Eric Miao
2012-08-06 16:36                         ` Mark Brown
2012-08-07 15:19                           ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333777207-4151-1-git-send-email-olof@lixom.net \
    --to=olof@lixom.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®