* [PATCH] gpio: Move DT support code into drivers/gpio
@ 2012-04-07 20:37 Grant Likely
2012-04-11 7:51 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2012-04-07 20:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Grant Likely, Rob Herring, Linus Walleij
The code in drivers/of/gpio.c isn't shared by any other subsystem since it
is all gpiolib specific. drivers/gpio is a better place to maintain these
functions.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/gpio/Kconfig | 4 ++++
drivers/gpio/Makefile | 1 +
drivers/{of/gpio.c => gpio/gpiolib-of.c} | 0
drivers/of/Kconfig | 6 ------
drivers/of/Makefile | 1 -
5 files changed, 5 insertions(+), 7 deletions(-)
rename drivers/{of/gpio.c => gpio/gpiolib-of.c} (100%)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index e6862f1..1042c3f 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -37,6 +37,10 @@ menuconfig GPIOLIB
if GPIOLIB
+config OF_GPIO
+ def_bool y
+ depends on OF && !SPARC
+
config DEBUG_GPIO
bool "Debug GPIO calls"
depends on DEBUG_KERNEL
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 007f54b..1c2f6c0 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -3,6 +3,7 @@
ccflags-$(CONFIG_DEBUG_GPIO) += -DDEBUG
obj-$(CONFIG_GPIOLIB) += gpiolib.o devres.o
+obj-$(CONFIG_OF_GPIO) += gpiolib-of.o
# Device drivers. Generally keep list sorted alphabetically
obj-$(CONFIG_GPIO_GENERIC) += gpio-generic.o
diff --git a/drivers/of/gpio.c b/drivers/gpio/gpiolib-of.c
similarity index 100%
rename from drivers/of/gpio.c
rename to drivers/gpio/gpiolib-of.c
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 8e84ce9..ce00d11 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -51,12 +51,6 @@ config OF_IRQ
config OF_DEVICE
def_bool y
-config OF_GPIO
- def_bool y
- depends on GPIOLIB && !SPARC
- help
- OpenFirmware GPIO accessors
-
config OF_I2C
def_tristate I2C
depends on I2C && !SPARC
diff --git a/drivers/of/Makefile b/drivers/of/Makefile
index aa90e60..aff2c62 100644
--- a/drivers/of/Makefile
+++ b/drivers/of/Makefile
@@ -4,7 +4,6 @@ obj-$(CONFIG_OF_PROMTREE) += pdt.o
obj-$(CONFIG_OF_ADDRESS) += address.o
obj-$(CONFIG_OF_IRQ) += irq.o
obj-$(CONFIG_OF_DEVICE) += device.o platform.o
-obj-$(CONFIG_OF_GPIO) += gpio.o
obj-$(CONFIG_OF_I2C) += of_i2c.o
obj-$(CONFIG_OF_NET) += of_net.o
obj-$(CONFIG_OF_SPI) += of_spi.o
--
1.7.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: Move DT support code into drivers/gpio
2012-04-07 20:37 [PATCH] gpio: Move DT support code into drivers/gpio Grant Likely
@ 2012-04-11 7:51 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-04-11 7:51 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel, Rob Herring, Linus Walleij
On Sat, Apr 7, 2012 at 10:37 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
> The code in drivers/of/gpio.c isn't shared by any other subsystem since it
> is all gpiolib specific. drivers/gpio is a better place to maintain these
> functions.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Linus Walleij <linus.walleij@stericsson.com>
Looks good to me.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-11 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-07 20:37 [PATCH] gpio: Move DT support code into drivers/gpio Grant Likely
2012-04-11 7:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®