* [PATCH] Removed less than zero check, since Schedule_timeout return value is guaranteed to be non-negative
@ 2012-04-10 9:02 Sasikantha babu
0 siblings, 0 replies; only message in thread
From: Sasikantha babu @ 2012-04-10 9:02 UTC (permalink / raw)
To: Paul Gortmaker, Thomas Gleixner, Ingo Molnar
Cc: linux-kernel, Sasikantha babu
validating timeout against negiatve value is not required, schedule_timeout always returns >= 0.
If someone passes timeout as negative value, Instead of simply returning -ETIME we have to warn them (schedule_timeout
is already doing it by dumping stack and priniting an error message) about it.
We must return -ETIME on timer expiry not for invaild timeouts.
Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
---
kernel/semaphore.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/semaphore.c b/kernel/semaphore.c
index 60636a4..029c05b 100644
--- a/kernel/semaphore.c
+++ b/kernel/semaphore.c
@@ -214,7 +214,7 @@ static inline int __sched __down_common(struct semaphore *sem, long state,
for (;;) {
if (signal_pending_state(state, task))
goto interrupted;
- if (timeout <= 0)
+ if (!timeout)
goto timed_out;
__set_task_state(task, state);
raw_spin_unlock_irq(&sem->lock);
--
1.7.3.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-04-10 9:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 9:02 [PATCH] Removed less than zero check, since Schedule_timeout return value is guaranteed to be non-negative Sasikantha babu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®