* [PATCH] virtio_ring: remove unused code in virtqueue_notify()
@ 2012-04-13 3:26 zwu.kernel
2012-04-13 8:45 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: zwu.kernel @ 2012-04-13 3:26 UTC (permalink / raw)
To: linux-kernel; +Cc: rusty, stefanha, Zhi Yong Wu
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
drivers/virtio/virtio_ring.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 5aa43c3..c6a54e6 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);
*/
void virtqueue_notify(struct virtqueue *_vq)
{
- struct vring_virtqueue *vq = to_vvq(_vq);
-
/* Prod other side to tell it about changes. */
vq->notify(_vq);
}
--
1.7.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] virtio_ring: remove unused code in virtqueue_notify()
2012-04-13 3:26 [PATCH] virtio_ring: remove unused code in virtqueue_notify() zwu.kernel
@ 2012-04-13 8:45 ` Stefan Hajnoczi
2012-04-13 8:48 ` Zhi Yong Wu
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-04-13 8:45 UTC (permalink / raw)
To: zwu.kernel; +Cc: linux-kernel, rusty, Zhi Yong Wu
On Fri, Apr 13, 2012 at 11:26:03AM +0800, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> drivers/virtio/virtio_ring.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 5aa43c3..c6a54e6 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);
> */
> void virtqueue_notify(struct virtqueue *_vq)
> {
> - struct vring_virtqueue *vq = to_vvq(_vq);
> -
> /* Prod other side to tell it about changes. */
> vq->notify(_vq);
vq->notify() uses 'vq'. How does this work?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] virtio_ring: remove unused code in virtqueue_notify()
2012-04-13 8:45 ` Stefan Hajnoczi
@ 2012-04-13 8:48 ` Zhi Yong Wu
0 siblings, 0 replies; 3+ messages in thread
From: Zhi Yong Wu @ 2012-04-13 8:48 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: linux-kernel, rusty, Zhi Yong Wu
On Fri, Apr 13, 2012 at 4:45 PM, Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com> wrote:
> On Fri, Apr 13, 2012 at 11:26:03AM +0800, zwu.kernel@gmail.com wrote:
>> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>> ---
>> drivers/virtio/virtio_ring.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>> index 5aa43c3..c6a54e6 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);
>> */
>> void virtqueue_notify(struct virtqueue *_vq)
>> {
>> - struct vring_virtqueue *vq = to_vvq(_vq);
>> -
>> /* Prod other side to tell it about changes. */
>> vq->notify(_vq);
>
> vq->notify() uses 'vq'. How does this work?
sorry, i missed vq->notify. thanks
>
> Stefan
>
--
Regards,
Zhi Yong Wu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-13 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 3:26 [PATCH] virtio_ring: remove unused code in virtqueue_notify() zwu.kernel
2012-04-13 8:45 ` Stefan Hajnoczi
2012-04-13 8:48 ` Zhi Yong Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®