[PATCH] CodingStyle: add kmalloc_array() to memory allocators

[PATCH] CodingStyle: add kmalloc_array() to memory allocators

[Xi Wang]

Add the new kmalloc_array() to the list of general-purpose memory
allocators in chapter 14.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: Jesper Juhl <jj@chaosbits.net>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Pekka Enberg <penberg@kernel.org>
---
 Documentation/CodingStyle |   16 ++++++++++++++--
 1 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index c58b236..cb9258b 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -671,8 +671,9 @@ ones already enabled by DEBUG.
 		Chapter 14: Allocating memory
 
 The kernel provides the following general purpose memory allocators:
-kmalloc(), kzalloc(), kcalloc(), vmalloc(), and vzalloc().  Please refer to
-the API documentation for further information about them.
+kmalloc(), kzalloc(), kmalloc_array(), kcalloc(), vmalloc(), and
+vzalloc().  Please refer to the API documentation for further information
+about them.
 
 The preferred form for passing a size of a struct is the following:
 
@@ -686,6 +687,17 @@ Casting the return value which is a void pointer is redundant. The conversion
 from void pointer to any other pointer type is guaranteed by the C programming
 language.
 
+The preferred form for allocating an array is the following:
+
+	p = kmalloc_array(n, sizeof(...), ...);
+
+The preferred form for allocating a zeroed array is the following:
+
+	p = kcalloc(n, sizeof(...), ...);
+
+Both forms check for overflow on the allocation size n * sizeof(...),
+and return NULL if that occurred.
+
 
 		Chapter 15: The inline disease
 
-- 
1.7.5.4

Re: [PATCH] CodingStyle: add kmalloc_array() to memory allocators

[Pekka Enberg]

On Sat, 14 Apr 2012, Xi Wang wrote:
> Add the new kmalloc_array() to the list of general-purpose memory
> allocators in chapter 14.
> 
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> Cc: Jesper Juhl <jj@chaosbits.net>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Pekka Enberg <penberg@kernel.org>
> ---

Acked-by: Pekka Enberg <penberg@kernel.org>

Re: [PATCH] CodingStyle: add kmalloc_array() to memory allocators

[Jesper Juhl]

On Sat, 14 Apr 2012, Xi Wang wrote:

> Add the new kmalloc_array() to the list of general-purpose memory
> allocators in chapter 14.
> 
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> Cc: Jesper Juhl <jj@chaosbits.net>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Pekka Enberg <penberg@kernel.org>

Looks OK to me.

Acked-by: Jesper Juhl <jj@chaosbits.net>

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.