mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Whitcroft <apw@canonical.com>
Subject: [PATCH] checkpatch: revert --strict test for net/ and drivers/net block comment style
Date: Mon, 16 Apr 2012 13:35:11 -0600	[thread overview]
Message-ID: <1334604911.2726.2.camel@joe2Laptop> (raw)
In-Reply-To: <4F8C76A0.2050601@xenotime.net>

Revert the --strict test for the old preferred block
comment style in drivers/net and net/

Signed-off-by: Joe Perches <joe@perches.com>

---

grumble.  Don't reply to email from internet cafes.

On Mon, 2012-04-16 at 12:44 -0700, Randy Dunlap wrote:
> On 04/16/2012 02:17 AM, Ingo Molnar wrote:
> >   aad4f6149831 checkpatch: add --strict tests for braces, comments and casts
> > made the default checkpatch run complain about the following 
> > perfectly fine multi-line comment block:

No, it didn't.

It only made checkpatch complain if --strict was
added to the command line arguments.

I don't care about the comment style, it is/was
David Miller's preferred style for drivers/net and
net/

I think a straight revert isn't appropriate.

Here's one that just removes the comment check.

 scripts/checkpatch.pl |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index de639ee..faea0ec 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1869,12 +1869,6 @@ sub process {
 			    "No space is necessary after a cast\n" . $hereprev);
 		}
 
-		if ($rawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
-		    $prevrawline =~ /^\+[ \t]*$/) {
-			CHK("BLOCK_COMMENT_STYLE",
-			    "Don't begin block comments with only a /* line, use /* comment...\n" . $hereprev);
-		}
-
 # check for spaces at the beginning of a line.
 # Exceptions:
 #  1) within comments



  parent reply	other threads:[~2012-04-16 19:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  9:17 Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts Ingo Molnar
2012-04-16 18:27 ` David Miller
2012-04-16 19:09   ` Linus Torvalds
2012-04-16 19:13     ` David Miller
2012-04-16 20:26   ` Ingo Molnar
2012-04-16 20:34     ` Joe Perches
2012-04-16 20:34     ` Ingo Molnar
2012-04-16 21:00       ` David Miller
2012-04-17  3:30         ` Steven Rostedt
2012-04-25  8:33         ` Ingo Molnar
2012-04-16 20:58     ` David Miller
2012-04-25  8:42       ` Ingo Molnar
2012-04-16 19:44 ` Randy Dunlap
2012-04-16 19:32   ` [PATCH] checkpatch: revert --strict test for net/ and drivers/net block comment style Joe Perches
2012-04-16 19:35   ` Joe Perches [this message]
2012-04-16 20:28     ` Ingo Molnar
2012-04-16 20:33       ` Linus Torvalds
2012-04-17 10:07         ` Ingo Molnar
2012-04-25 22:42           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334604911.2726.2.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome