From: David Miller <davem@davemloft.net>
To: mingo@kernel.org
Cc: joe@perches.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
apw@canonical.com
Subject: Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts
Date: Mon, 16 Apr 2012 14:27:28 -0400 (EDT) [thread overview]
Message-ID: <20120416.142728.864894452301706752.davem@davemloft.net> (raw)
In-Reply-To: <20120416091719.GA4113@gmail.com>
From: Ingo Molnar <mingo@kernel.org>
Date: Mon, 16 Apr 2012 11:17:20 +0200
>
> This recent checkpatch commit, added in v3.4-rc1:
>
> aad4f6149831 checkpatch: add --strict tests for braces, comments and casts
>
> made the default checkpatch run complain about the following
> perfectly fine multi-line comment block:
>
> + rdp->qlen_lazy = 0;
> + rdp->qlen = 0;
> +
> + /*
> + * Adopt all callbacks. The outgoing CPU was in no shape
> + * to advance them, so make them all go through a full
> + * grace period.
> + */
> + *receive_rdp->nxttail[RCU_NEXT_TAIL] = rdp->nxtlist;
>
I would like to formally propose that we change CodingStyle so that
our comments are of the form:
/* XXX
* YYY
*/
So that we can save one line of vertical space.
We've adopted this all across the networking, and the code looks a
lot nicer as well as allowing more actual code onto a single window
of text.
next prev parent reply other threads:[~2012-04-16 18:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 9:17 Ingo Molnar
2012-04-16 18:27 ` David Miller [this message]
2012-04-16 19:09 ` Linus Torvalds
2012-04-16 19:13 ` David Miller
2012-04-16 20:26 ` Ingo Molnar
2012-04-16 20:34 ` Joe Perches
2012-04-16 20:34 ` Ingo Molnar
2012-04-16 21:00 ` David Miller
2012-04-17 3:30 ` Steven Rostedt
2012-04-25 8:33 ` Ingo Molnar
2012-04-16 20:58 ` David Miller
2012-04-25 8:42 ` Ingo Molnar
2012-04-16 19:44 ` Randy Dunlap
2012-04-16 19:32 ` [PATCH] checkpatch: revert --strict test for net/ and drivers/net block comment style Joe Perches
2012-04-16 19:35 ` Joe Perches
2012-04-16 20:28 ` Ingo Molnar
2012-04-16 20:33 ` Linus Torvalds
2012-04-17 10:07 ` Ingo Molnar
2012-04-25 22:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416.142728.864894452301706752.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®