mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][GIT PULL] ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
@ 2012-04-24 21:50 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2012-04-24 21:50 UTC (permalink / raw)
  To: LKML; +Cc: Linus Torvalds, Russ Dill


Linus,

Please pull the latest ktest-v3.4-rc4 tree, which can be found at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git
ktest-v3.4-rc4

Head SHA1: 97f106a13ae6ff0bd8f37763ceab1644a77ca119


Russ Dill (1):
      ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP

----
 tools/testing/ktest/ktest.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------
commit 2bc90df49d62e213acaaea84b45abd9d6ceaa4c1
Author: Russ Dill <Russ.Dill@ti.com>
Date:   Mon Apr 23 19:43:00 2012 -0700

    ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
    
    When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
    testing, build failures are treated as boot or test failures and
    'git bisect bad' is executed instead of 'git bisect skip'. This is because
    the $ret value of -1 is treated as a build failure, but the $reverse_bisect
    logic does not properly handle this.
    
    Simple fix, only invert it if it is positive.
    
    Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.com
    
    Signed-off-by: Russ Dill <Russ.Dill@ti.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 95d6a6f..d2ede59 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2192,7 +2192,7 @@ sub run_bisect {
     }
 
     # Are we looking for where it worked, not failed?
-    if ($reverse_bisect) {
+    if ($reverse_bisect && $ret >= 0) {
 	$ret = !$ret;
     }
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-04-24 21:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-24 21:50 [PATCH][GIT PULL] ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®