From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: fweisbec@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ftrace: No return value for ftrace_process_locs
Date: Wed, 25 Apr 2012 07:29:43 -0400 [thread overview]
Message-ID: <1335353383.28106.162.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1335342219-2782-4-git-send-email-jolsa@redhat.com>
On Wed, 2012-04-25 at 10:23 +0200, Jiri Olsa wrote:
> The return value of ftrace_process_locs is never checked. The function
> tries to update as many calls as possible and in case of error there's
> either warning output or ftrace_bug call.
No, the real bug is...
> #ifdef CONFIG_MODULES
> @@ -3789,9 +3784,9 @@ void __init ftrace_init(void)
>
> last_ftrace_enabled = ftrace_enabled = 1;
>
> - ret = ftrace_process_locs(NULL,
> - __start_mcount_loc,
> - __stop_mcount_loc);
> + ftrace_process_locs(NULL,
> + __start_mcount_loc,
> + __stop_mcount_loc);
We should check the return code of ftrace_process_locs().
-- Steve
>
> ret = register_module_notifier(&ftrace_module_nb);
> if (ret)
next prev parent reply other threads:[~2012-04-25 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 8:23 [PATCH 0/4] tracing: Various cleanups Jiri Olsa
2012-04-25 8:23 ` [PATCH 1/4] ftrace: Remove unused code ftrace related code Jiri Olsa
2012-04-25 11:21 ` Steven Rostedt
2012-04-25 11:34 ` Jiri Olsa
2012-04-25 8:23 ` [PATCH 2/4] ftrace: Remove unused ftrace_update_time variable/code Jiri Olsa
2012-04-25 11:26 ` Steven Rostedt
2012-04-25 8:23 ` [PATCH 3/4] ftrace: No return value for ftrace_process_locs Jiri Olsa
2012-04-25 11:29 ` Steven Rostedt [this message]
2012-05-08 14:19 ` Steven Rostedt
2012-05-12 15:01 ` Jiri Olsa
2012-04-25 8:23 ` [PATCH 4/4] tracing: Use seq_*_private interface for some seq files Jiri Olsa
2012-05-10 8:56 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335353383.28106.162.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®