Re: [PATCH 1/4] ftrace: Remove unused code ftrace related code

[Jiri Olsa <jolsa@redhat.com>]

On Wed, Apr 25, 2012 at 07:21:29AM -0400, Steven Rostedt wrote:
> On Wed, 2012-04-25 at 10:23 +0200, Jiri Olsa wrote:
> > Removing unused functions:
> >   ftrace_rec_iter_record
> >   ftrace_rec_iter_next
> >   ftrace_rec_iter_start
> >   ftrace_location
> 
> No, no, no!!
> 
> These are used in the core infrastructure of removing stop machine from
> ftrace.
> 
> Correct, no one currently uses them, but that's because they were needed
> for the arch dependent code. I have patches for both PPC and x86 to
> remove stop machine, and I want the PPC changes to go through the PPC
> tree.
> 
> I pushed the changes for the core infrastructure so that we don't have
> dependencies between different archs.
> 
> Please read: commit c88fd8634ea68e74c7d19fd2621b4078fd22864c
> 
> If you remove these you would break:
> 
>  https://lkml.org/lkml/2012/4/23/620
> 
> Big NACK!

I see, thought they were just leftover not seeing any user..
big sorry then ;-)

jirka

> 
> -- Steve
> 
> 
>