From: Robert Richter <robert.richter@amd.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
Robert Richter <robert.richter@amd.com>
Subject: [PATCH 5/7] perf, tools: Add raw event support for dynamic allocated pmus
Date: Wed, 2 May 2012 20:26:30 +0200 [thread overview]
Message-ID: <1335983192-23731-6-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1335983192-23731-1-git-send-email-robert.richter@amd.com>
This patch extends the event parser to pass raw config values to a
dynamic allocated pmu. The following event syntax is supported now:
<pmu_name>:<raw_config_value>:<modifier>
Example for the ibs pmu:
# perf record -a -e ibs_op:r000 ...
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
tools/perf/util/parse-events.c | 20 +++++++++++++++-----
tools/perf/util/parse-events.h | 2 +-
tools/perf/util/parse-events.y | 7 ++++++-
tools/perf/util/pmu-ibs.c | 4 ++++
4 files changed, 26 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index d572204..8ad536c 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -524,6 +524,9 @@ static int parse_events_add_tracepoint(struct list_head *list, int *idx,
{
int ret;
+ if (!event)
+ return -ENOENT;
+
ret = debugfs_valid_mountpoint(tracing_events_path);
if (ret)
return ret;
@@ -533,8 +536,9 @@ static int parse_events_add_tracepoint(struct list_head *list, int *idx,
add_tracepoint(list, idx, sys, event);
}
-static int __parse_events_add_generic_event(struct list_head *list, int *idx,
- char *sys, char *event)
+static int
+__parse_events_add_generic_event(struct list_head *list, int *idx, char *sys,
+ char *event, unsigned long config)
{
struct perf_event_attr attr;
char name[MAX_NAME_LEN];
@@ -545,12 +549,18 @@ static int __parse_events_add_generic_event(struct list_head *list, int *idx,
if (ret)
return ret;
- snprintf(name, MAX_NAME_LEN, "%s:%s", sys, event);
+ if (event)
+ snprintf(name, MAX_NAME_LEN, "%s:%s", sys, event);
+ else
+ snprintf(name, MAX_NAME_LEN, "%s:r%lx", sys, config);
+
+ attr.config |= config;
+
return add_event(list, idx, &attr, name);
}
int parse_events_add_generic_event(struct list_head *list, int *idx,
- char *sys, char *event)
+ char *sys, char *event, unsigned long config)
{
int ret1, ret2;
@@ -558,7 +568,7 @@ int parse_events_add_generic_event(struct list_head *list, int *idx,
if (!ret1)
return 0;
- ret2 = __parse_events_add_generic_event(list, idx, sys, event);
+ ret2 = __parse_events_add_generic_event(list, idx, sys, event, config);
if (!ret2)
return 0;
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index e9df741..88950d8 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -63,7 +63,7 @@ int parse_events__new_term(struct parse_events__term **term, int type,
void parse_events__free_terms(struct list_head *terms);
int parse_events_modifier(struct list_head *list __used, char *str __used);
int parse_events_add_generic_event(struct list_head *list, int *idx,
- char *sys, char *event);
+ char *sys, char *event, unsigned long config);
int parse_events_add_raw(struct perf_evlist *evlist, unsigned long config,
unsigned long config1, unsigned long config2,
char *mod);
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 659b5e8..d07fddd 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -134,7 +134,12 @@ PE_PREFIX_MEM PE_VALUE sep_dc
event_legacy_generic:
PE_NAME ':' PE_NAME
{
- ABORT_ON(parse_events_add_generic_event(list_event, idx, $1, $3));
+ ABORT_ON(parse_events_add_generic_event(list_event, idx, $1, $3, 0));
+}
+|
+PE_NAME ':' PE_RAW
+{
+ ABORT_ON(parse_events_add_generic_event(list_event, idx, $1, NULL, $3));
}
event_legacy_numeric:
diff --git a/tools/perf/util/pmu-ibs.c b/tools/perf/util/pmu-ibs.c
index 604cb8c..a5468c8 100644
--- a/tools/perf/util/pmu-ibs.c
+++ b/tools/perf/util/pmu-ibs.c
@@ -375,6 +375,9 @@ static int ibs_parse_event(struct perf_event_attr *attr, char *sys, char *name)
if (strcmp("ibs_op", sys) && strcmp("ibs_fetch", sys))
return -ENOENT;
+ if (!name)
+ goto out; /* raw event if name is NULL */
+
for (event = events; event->id; event++) {
if (!strcmp(event->name + strlen(sys) + 1, name))
goto match;
@@ -384,6 +387,7 @@ static int ibs_parse_event(struct perf_event_attr *attr, char *sys, char *name)
match:
/* pseudo event found */
attr->config1 = event->config;
+out:
attr->sample_type = PERF_SAMPLE_CPU;
return 0;
--
1.7.8.4
next prev parent reply other threads:[~2012-05-02 18:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 18:26 [PATCH 0/7] perf/x86-ibs and tools: Add support for AMD IBS Robert Richter
2012-05-02 18:26 ` [PATCH 1/7] perf tools: Fix generation of pmu list Robert Richter
2012-05-02 18:26 ` [PATCH 2/7] perf tools: Add basic dynamic PMU support Robert Richter
2012-05-02 18:26 ` [PATCH 3/7] perf tools: Add parser for dynamic PMU events Robert Richter
2012-05-07 11:01 ` Peter Zijlstra
2012-05-07 17:05 ` Robert Richter
2012-05-07 17:10 ` Peter Zijlstra
2012-05-02 18:26 ` [PATCH 4/7] perf/x86-ibs: Add support for IBS pseudo events Robert Richter
2012-05-07 11:00 ` Peter Zijlstra
2012-05-07 14:47 ` Robert Richter
2012-05-07 15:15 ` Peter Zijlstra
2012-05-07 16:03 ` Robert Richter
2012-05-07 12:08 ` Peter Zijlstra
2012-05-07 13:03 ` Peter Zijlstra
2012-05-07 15:44 ` Robert Richter
2012-05-07 15:51 ` Peter Zijlstra
2012-05-07 15:58 ` Robert Richter
2012-05-07 15:21 ` Stephane Eranian
2012-05-07 15:29 ` Peter Zijlstra
2012-05-07 15:52 ` Robert Richter
2012-05-02 18:26 ` Robert Richter [this message]
2012-05-07 13:05 ` [PATCH 5/7] perf, tools: Add raw event support for dynamic allocated pmus Peter Zijlstra
2012-05-07 14:20 ` Peter Zijlstra
2012-05-02 18:26 ` [PATCH 6/7] perf tools: Add pmu mappings to header information Robert Richter
2012-05-02 18:26 ` [PATCH 7/7] perf script: Add script to collect and display IBS samples Robert Richter
2012-05-31 15:24 ` [PATCH 0/7] perf/x86-ibs and tools: Add support for AMD IBS Stephane Eranian
2012-05-31 15:51 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335983192-23731-6-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome