mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] perf tools: Add parser for dynamic PMU events
Date: Mon, 07 May 2012 19:10:55 +0200	[thread overview]
Message-ID: <1336410655.27020.74.camel@laptop> (raw)
In-Reply-To: <20120507170549.GM18810@erda.amd.com>

On Mon, 2012-05-07 at 19:05 +0200, Robert Richter wrote:
> On 07.05.12 13:01:03, Peter Zijlstra wrote:
> > On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote:
> > > This patch adds support for pmu specific event parsers by extending
> > > the pmu handler. The event syntax is the same as for tracepoints:
> > > 
> > >  <subsys>:<name>:<modifier> 
> > 
> > I really don't like this
> > 
> > > -          event_legacy_tracepoint sep_dc |
> > > +          event_legacy_generic sep_dc |
> > 
> > That 'legacy' in there is a good hint you shouldn't be using this.
> > 
> > Ideally I'd get rid of all legacy formats eventually, we really
> > shouldn't be adding new ones. 
> 
> Anyway, we need something like this to specify event names (pseudo
> event names in case of ibs) and userland filter options. Though, it
> must not necessarily this syntax but something else. The one above
> looks esthetic to me while some other event syntax is close to a perl
> regex. ;)

Jiri and Yan Zheng are working on something that would allow:

 ibs_op/foo/

Their solution will initially get foo from sysfs (ibs_op/events/foo),
but an external lookup should also get there. Stephane also wants/needs
something like that to plug the Intel event names in.




  reply	other threads:[~2012-05-07 17:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 18:26 [PATCH 0/7] perf/x86-ibs and tools: Add support for AMD IBS Robert Richter
2012-05-02 18:26 ` [PATCH 1/7] perf tools: Fix generation of pmu list Robert Richter
2012-05-02 18:26 ` [PATCH 2/7] perf tools: Add basic dynamic PMU support Robert Richter
2012-05-02 18:26 ` [PATCH 3/7] perf tools: Add parser for dynamic PMU events Robert Richter
2012-05-07 11:01   ` Peter Zijlstra
2012-05-07 17:05     ` Robert Richter
2012-05-07 17:10       ` Peter Zijlstra [this message]
2012-05-02 18:26 ` [PATCH 4/7] perf/x86-ibs: Add support for IBS pseudo events Robert Richter
2012-05-07 11:00   ` Peter Zijlstra
2012-05-07 14:47     ` Robert Richter
2012-05-07 15:15       ` Peter Zijlstra
2012-05-07 16:03         ` Robert Richter
2012-05-07 12:08   ` Peter Zijlstra
2012-05-07 13:03   ` Peter Zijlstra
2012-05-07 15:44     ` Robert Richter
2012-05-07 15:51       ` Peter Zijlstra
2012-05-07 15:58         ` Robert Richter
2012-05-07 15:21   ` Stephane Eranian
2012-05-07 15:29     ` Peter Zijlstra
2012-05-07 15:52       ` Robert Richter
2012-05-02 18:26 ` [PATCH 5/7] perf, tools: Add raw event support for dynamic allocated pmus Robert Richter
2012-05-07 13:05   ` Peter Zijlstra
2012-05-07 14:20     ` Peter Zijlstra
2012-05-02 18:26 ` [PATCH 6/7] perf tools: Add pmu mappings to header information Robert Richter
2012-05-02 18:26 ` [PATCH 7/7] perf script: Add script to collect and display IBS samples Robert Richter
2012-05-31 15:24 ` [PATCH 0/7] perf/x86-ibs and tools: Add support for AMD IBS Stephane Eranian
2012-05-31 15:51   ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336410655.27020.74.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome