From: Eric Nelson <eric.nelson@boundarydevices.com>
To: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, u-boot@lists.denx.de,
rylv50@freescale.com, marex@denx.de, vapier@gentoo.org,
Eric Nelson <eric.nelson@boundarydevices.com>
Subject: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line
Date: Wed, 2 May 2012 20:32:18 -0700 [thread overview]
Message-ID: <1336015938-3174-1-git-send-email-eric.nelson@boundarydevices.com> (raw)
In-Reply-To: <http://lists.denx.de/pipermail/u-boot/2012-May/123595.html>
This tests for a bad habits of mine like this:
return 0 ;
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
scripts/checkpatch.pl | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..0e6977e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3227,6 +3227,12 @@ sub process {
"Statements terminations use 1 semicolon\n" . $herecurr);
}
+# check for whitespace before semicolon - not allowed at end-of-line
+ if ($line =~ /\s+;$/) {
+ WARN("SPACEBEFORE_SEMICOLON",
+ "Whitespace before semicolon\n" . $herecurr);
+ }
+
# check for gcc specific __FUNCTION__
if ($line =~ /__FUNCTION__/) {
WARN("USE_FUNC",
--
1.7.9
next parent reply other threads:[~2012-05-03 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123595.html>
2012-05-03 3:32 ` Eric Nelson [this message]
2012-05-03 3:58 ` Joe Perches
2012-05-03 13:41 ` Eric Nelson
2012-05-03 15:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336015938-3174-1-git-send-email-eric.nelson@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=rylv50@freescale.com \
--cc=u-boot@lists.denx.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®