* [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line [not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123595.html> @ 2012-05-03 3:32 ` Eric Nelson 2012-05-03 3:58 ` Joe Perches 0 siblings, 1 reply; 4+ messages in thread From: Eric Nelson @ 2012-05-03 3:32 UTC (permalink / raw) To: linux-kernel; +Cc: linux-kbuild, u-boot, rylv50, marex, vapier, Eric Nelson This tests for a bad habits of mine like this: return 0 ; Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> --- scripts/checkpatch.pl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a3b9782..0e6977e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3227,6 +3227,12 @@ sub process { "Statements terminations use 1 semicolon\n" . $herecurr); } +# check for whitespace before semicolon - not allowed at end-of-line + if ($line =~ /\s+;$/) { + WARN("SPACEBEFORE_SEMICOLON", + "Whitespace before semicolon\n" . $herecurr); + } + # check for gcc specific __FUNCTION__ if ($line =~ /__FUNCTION__/) { WARN("USE_FUNC", -- 1.7.9 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line 2012-05-03 3:32 ` [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line Eric Nelson @ 2012-05-03 3:58 ` Joe Perches 2012-05-03 13:41 ` Eric Nelson 0 siblings, 1 reply; 4+ messages in thread From: Joe Perches @ 2012-05-03 3:58 UTC (permalink / raw) To: Eric Nelson; +Cc: linux-kernel, linux-kbuild, u-boot, rylv50, marex, vapier On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote: > This tests for a bad habits of mine like this: > > return 0 ; > > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> > --- > scripts/checkpatch.pl | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index a3b9782..0e6977e 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3227,6 +3227,12 @@ sub process { > "Statements terminations use 1 semicolon\n" . $herecurr); > } > > +# check for whitespace before semicolon - not allowed at end-of-line > + if ($line =~ /\s+;$/) { if ($line =~ /\s+;\s*$/) > + WARN("SPACEBEFORE_SEMICOLON", WARN("SPACING", > + "Whitespace before semicolon\n" . $herecurr); > + } > + ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line 2012-05-03 3:58 ` Joe Perches @ 2012-05-03 13:41 ` Eric Nelson 2012-05-03 15:52 ` Joe Perches 0 siblings, 1 reply; 4+ messages in thread From: Eric Nelson @ 2012-05-03 13:41 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, linux-kbuild, u-boot, rylv50, marex, vapier Thanks Joe, On 05/02/2012 08:58 PM, Joe Perches wrote: > On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote: >> This tests for a bad habits of mine like this: >> >> return 0 ; >> >> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com> >> --- >> scripts/checkpatch.pl | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index a3b9782..0e6977e 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -3227,6 +3227,12 @@ sub process { >> "Statements terminations use 1 semicolon\n" . $herecurr); >> } >> >> +# check for whitespace before semicolon - not allowed at end-of-line >> + if ($line =~ /\s+;$/) { > > if ($line =~ /\s+;\s*$/) > Won't the extra space at end of line be caught by other tests? >> + WARN("SPACEBEFORE_SEMICOLON", > > WARN("SPACING", > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line 2012-05-03 13:41 ` Eric Nelson @ 2012-05-03 15:52 ` Joe Perches 0 siblings, 0 replies; 4+ messages in thread From: Joe Perches @ 2012-05-03 15:52 UTC (permalink / raw) To: Eric Nelson; +Cc: linux-kernel, linux-kbuild, u-boot, rylv50, marex, vapier On Thu, 2012-05-03 at 06:41 -0700, Eric Nelson wrote: > >> +# check for whitespace before semicolon - not allowed at end-of-line > >> + if ($line =~ /\s+;$/) { > > > > if ($line =~ /\s+;\s*$/) > Won't the extra space at end of line be caught by other tests? Yes it will. You want the test to find the space before semicolon whenever it exists. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-03 15:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123595.html>
2012-05-03 3:32 ` [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line Eric Nelson
2012-05-03 3:58 ` Joe Perches
2012-05-03 13:41 ` Eric Nelson
2012-05-03 15:52 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®