From: Artem Bityutskiy <dedekind1@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH 2/2] Makefile: remove useless warning
Date: Fri, 4 May 2012 10:42:35 +0300 [thread overview]
Message-ID: <1336117355-21348-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1336117355-21348-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
This patch removes annoying warning:
Makefile:708: "WARNING: Appending $KCFLAGS (-Wno-sign-compare) from command line to kernel $CFLAGS"
which is printed every time I use KCFLAFS. The commit which introduced the
warning:
69ee0b3 kbuild: do not pick up CFLAGS from the environment
tells about the problems when people have CFLAGS in their environment,
then switches to KCFLAFS which should be enough to solve the issue, but
it anyway introduces a warning. I think it is too much and I find this
warning very annoying - why should we warn users when they use the
build system properly?
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
Makefile | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 2cba5db..53e6b7d 100644
--- a/Makefile
+++ b/Makefile
@@ -692,20 +692,14 @@ KBUILD_CFLAGS += $(warning)
endif
# Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments
-# But warn user when we do so
-warn-assign = \
-$(warning "WARNING: Appending $$K$(1) ($(K$(1))) from $(origin K$(1)) to kernel $$$(1)")
ifneq ($(KCPPFLAGS),)
- $(call warn-assign,CPPFLAGS)
KBUILD_CPPFLAGS += $(KCPPFLAGS)
endif
ifneq ($(KAFLAGS),)
- $(call warn-assign,AFLAGS)
KBUILD_AFLAGS += $(KAFLAGS)
endif
ifneq ($(KCFLAGS),)
- $(call warn-assign,CFLAGS)
KBUILD_CFLAGS += $(KCFLAGS)
endif
--
1.7.9.1
next prev parent reply other threads:[~2012-05-04 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 7:42 [PATCH 1/2] Makefile: make sure KCFLAGS options are at the end Artem Bityutskiy
2012-05-04 7:42 ` Artem Bityutskiy [this message]
2012-05-04 8:56 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336117355-21348-2-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome