mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Artem Bityutskiy <dedekind1@gmail.com>, Michal Marek <mmarek@suse.cz>
Cc: Michal Marek <mmarek@suse.cz>,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 1/2] Makefile: make sure KCFLAGS options are at the end
Date: Fri, 4 May 2012 10:56:35 +0200	[thread overview]
Message-ID: <20120504085635.GA13450@merkur.ravnborg.org> (raw)
In-Reply-To: <1336117355-21348-1-git-send-email-dedekind1@gmail.com>

On Fri, May 04, 2012 at 10:42:34AM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> When I build the kernel like this:
> 
> $ make W=1 KCFLAGS="-Wno-sign-compare"
> 
> the "-Wno-sign-compare" option is ignore. The reason is that we append gcc
> options associated with W=1 _after_ KCFLAGS, so W=1 overrides my KCFLAGS
> options. This patch tries to fix the issue by moving the "W=[123]" stiff
> from "scripts/Makefile.build" to the main Maikefile. This fixes the issue
> as well as this should be a small improvent because "scripts/Makefile.build"
> is parsed by make many times (I think for each file), bue we do not need
> to re-assign all the warnings stuff so many times - it is enough to do it
> only once.

Moving all the W=... support out of Makefile.build is a good thing,
as we really should do the evaluation only once.

But I detest that this is added to the top-level Makefile.
The top-level Makefile is full of all sort of strange stuff
already and very hard to navigate / update for this reason.

How about introducing a new file : scripts/Kbuild.config
This file should be included only _once_ from the top-level Makefile.
And it should contains all the trivial assignments to
CC, CFLAGS, etc...

Including exporting of variables so they a visible in sub-makes.

First step could be to move the W=... support, and then it could be
gradually extended.

Michal - any comments on this?

	Sam

      parent reply	other threads:[~2012-05-04  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04  7:42 Artem Bityutskiy
2012-05-04  7:42 ` [PATCH 2/2] Makefile: remove useless warning Artem Bityutskiy
2012-05-04  8:56 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120504085635.GA13450@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dedekind1@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®