mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
To: Manohar Vanga <manohar.vanga@cern.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 2/3] Staging: ipack: added support for the TEWS TPCI-200 carrier board
Date: Tue, 08 May 2012 10:58:00 +0200	[thread overview]
Message-ID: <1336467480.3617.11.camel@fourier.local.igalia.com> (raw)
In-Reply-To: <20120508081549.GB18595@becoht-mvanga>

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

On Tue, 2012-05-08 at 10:15 +0200, Manohar Vanga wrote:
[...]
> 
> Check whether the function exists or you could have trouble :)
> If you already added a check when registering to make sure this is always non-NULL then
> ignore this. I would recommend wrapping this up in some function:
> 
>     void tpci_slot_remove(struct tpci_slot *slot)
>     {
>         if (slot->dev->driver->ops->remove)
>         	slot->dev->driver->ops->remove(slot->dev);
>     }
> 

OK, I agree that this is better and clearer. 

I am fixing some minor stuff I saw (one extra newline in ipack.h,
convert to "static" some functions, etc)

I hope this will increase the code quality and readability. 

Thanks a lot for your reviews,

Sam 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-05-08  8:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08  7:43 [PATCH v3 1/3] Staging: IndustryPack bus for the Linux Kernel Samuel Iglesias Gonsalvez
2012-05-08  7:43 ` [PATCH v3 2/3] Staging: ipack: added support for the TEWS TPCI-200 carrier board Samuel Iglesias Gonsalvez
2012-05-08  8:15   ` Manohar Vanga
2012-05-08  8:58     ` Samuel Iglesias Gonsálvez [this message]
2012-05-08  7:43 ` [PATCH v3 3/3] Staging: ipack: add support for IP-OCTAL mezzanine board Samuel Iglesias Gonsalvez
2012-05-08  7:57 ` [PATCH v3 1/3] Staging: IndustryPack bus for the Linux Kernel Manohar Vanga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336467480.3617.11.camel@fourier.local.igalia.com \
    --to=siglesias@igalia.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manohar.vanga@cern.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®