From: Manohar Vanga <manohar.vanga@cern.ch>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 1/3] Staging: IndustryPack bus for the Linux Kernel
Date: Tue, 8 May 2012 09:57:51 +0200 [thread overview]
Message-ID: <20120508075751.GA18595@becoht-mvanga> (raw)
In-Reply-To: <1336463005-26234-1-git-send-email-siglesias@igalia.com>
Hey Samuel,
> [snip]
>
> +#define to_ipack_dev(device) container_of(device, struct ipack_device, dev)
>
> [snip]
>
> +#define to_ipack_driver(drv) container_of(drv, struct ipack_driver, driver)
These don't need to be public as only your bus driver uses them. You can move this
into the .c file.
--
/manohar
prev parent reply other threads:[~2012-05-08 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 7:43 Samuel Iglesias Gonsalvez
2012-05-08 7:43 ` [PATCH v3 2/3] Staging: ipack: added support for the TEWS TPCI-200 carrier board Samuel Iglesias Gonsalvez
2012-05-08 8:15 ` Manohar Vanga
2012-05-08 8:58 ` Samuel Iglesias Gonsálvez
2012-05-08 7:43 ` [PATCH v3 3/3] Staging: ipack: add support for IP-OCTAL mezzanine board Samuel Iglesias Gonsalvez
2012-05-08 7:57 ` Manohar Vanga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508075751.GA18595@becoht-mvanga \
--to=manohar.vanga@cern.ch \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®