mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: mingo@kernel.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	joerg.roedel@amd.com, paul.gortmaker@windriver.com
Subject: Re: [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X
Date: Wed, 09 May 2012 12:29:01 -0700	[thread overview]
Message-ID: <1336591741.4634.4.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <20120509185608.GA13435@merkur.ravnborg.org>

On Wed, 2012-05-09 at 20:56 +0200, Sam Ravnborg wrote:
> On Wed, May 09, 2012 at 11:46:35AM -0700, Suresh Siddha wrote:
> > change config_enabled() to use it as config_enabled(SMP) instead of
> > config_enabled(CONFIG_SMP).
> 
> You are breaking all existing users.

I checked the mainline and there were no users as far as I checked.
Referring to some upcoming code? Just curious to see why I missed.

> And CONFIG_ was included to allow better grepability.

Ok.

> If you insist on having a CONFIG less variant
> introduce a new variant for this.

I will drop this for now.

thanks,
suresh


  reply	other threads:[~2012-05-09 19:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 13:54 [git pull] irq remapping ops for x86 Joerg Roedel
2012-05-08  3:51 ` Ingo Molnar
2012-05-08  7:08   ` [PATCH 1/3] irq_remap: fix compiler warning with !CONFIG_IRQ_REMAP Suresh Siddha
2012-05-08 10:01     ` [tip:core/iommu] irq_remap: Fix compiler warning with CONFIG_IRQ_REMAP=y tip-bot for Suresh Siddha
2012-05-08  7:08   ` [PATCH 2/3] irq_remap: fix the UP build failure Suresh Siddha
2012-05-08  9:09     ` Ingo Molnar
2012-05-09  2:37       ` Suresh Siddha
2012-05-09  9:30         ` Ingo Molnar
2012-05-09 18:46           ` [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X Suresh Siddha
2012-05-09 18:46             ` [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP Suresh Siddha
2012-05-09 19:58               ` Suresh Siddha
2012-05-10  7:50                 ` Ingo Molnar
2012-05-10 18:19                   ` Suresh Siddha
2012-06-06 23:29                   ` [patch] " Suresh Siddha
2012-06-07  1:36                     ` Yinghai Lu
2012-06-07 20:31                       ` Suresh Siddha
2012-06-07 20:36                         ` Yinghai Lu
2012-06-07 20:56                           ` Suresh Siddha
2012-06-07 13:03                     ` Paul Gortmaker
2012-06-07 22:34                       ` Suresh Siddha
2012-06-15  1:28                       ` [patch] irq: use config_enabled(CONFIG_SMP) " Suresh Siddha
2012-06-15 14:23                         ` [tip:x86/apic] irq/apic: Use config_enabled(CONFIG_SMP) checks to clean up " tip-bot for Suresh Siddha
2012-05-09 18:56             ` [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X Sam Ravnborg
2012-05-09 19:29               ` Suresh Siddha [this message]
2012-05-09 20:05                 ` Sam Ravnborg
2012-05-10  6:05               ` Geert Uytterhoeven
2012-05-09 19:05             ` Linus Torvalds
2012-05-08 10:02     ` [tip:core/iommu] irq_remap: Fix UP build failure tip-bot for Suresh Siddha
2012-05-08  7:08   ` [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning Suresh Siddha
2012-05-08  9:15     ` Ingo Molnar
2012-05-08 10:03     ` [tip:core/iommu] irq_remap: Fix " tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336591741.4634.4.camel@sbsiddha-desk.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®