From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, joerg.roedel@amd.com,
paul.gortmaker@windriver.com, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP
Date: Thu, 07 Jun 2012 13:56:23 -0700 [thread overview]
Message-ID: <1339102584.28766.94.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <CAE9FiQX=UGETwk+j1YQzGSJQsvuTWBN1LzL_BbF2r5qS-EFG7Q@mail.gmail.com>
On Thu, 2012-06-07 at 13:36 -0700, Yinghai Lu wrote:
> On Thu, Jun 7, 2012 at 1:31 PM, Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> >>
> >> can you just use
> >> if (nr_cpu_ids > 1)
> >> checking instead
> >> if config_enabled(CONFIG_SMP)
> >
> > Idea is to not have any extra runtime checks if CONFIG_SMP is enabled
> > and which is when all the smp affinity routines are used/invoked.
>
> then could use
> if (NR_CPUS > 1)
What is the problem with using config_enabled(CONFIG_SMP)? People
looking for "CONFIG_SMP" can easily identify the dependency.
thanks,
suresh
next prev parent reply other threads:[~2012-06-07 20:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:54 [git pull] irq remapping ops for x86 Joerg Roedel
2012-05-08 3:51 ` Ingo Molnar
2012-05-08 7:08 ` [PATCH 1/3] irq_remap: fix compiler warning with !CONFIG_IRQ_REMAP Suresh Siddha
2012-05-08 10:01 ` [tip:core/iommu] irq_remap: Fix compiler warning with CONFIG_IRQ_REMAP=y tip-bot for Suresh Siddha
2012-05-08 7:08 ` [PATCH 2/3] irq_remap: fix the UP build failure Suresh Siddha
2012-05-08 9:09 ` Ingo Molnar
2012-05-09 2:37 ` Suresh Siddha
2012-05-09 9:30 ` Ingo Molnar
2012-05-09 18:46 ` [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X Suresh Siddha
2012-05-09 18:46 ` [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP Suresh Siddha
2012-05-09 19:58 ` Suresh Siddha
2012-05-10 7:50 ` Ingo Molnar
2012-05-10 18:19 ` Suresh Siddha
2012-06-06 23:29 ` [patch] " Suresh Siddha
2012-06-07 1:36 ` Yinghai Lu
2012-06-07 20:31 ` Suresh Siddha
2012-06-07 20:36 ` Yinghai Lu
2012-06-07 20:56 ` Suresh Siddha [this message]
2012-06-07 13:03 ` Paul Gortmaker
2012-06-07 22:34 ` Suresh Siddha
2012-06-15 1:28 ` [patch] irq: use config_enabled(CONFIG_SMP) " Suresh Siddha
2012-06-15 14:23 ` [tip:x86/apic] irq/apic: Use config_enabled(CONFIG_SMP) checks to clean up " tip-bot for Suresh Siddha
2012-05-09 18:56 ` [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X Sam Ravnborg
2012-05-09 19:29 ` Suresh Siddha
2012-05-09 20:05 ` Sam Ravnborg
2012-05-10 6:05 ` Geert Uytterhoeven
2012-05-09 19:05 ` Linus Torvalds
2012-05-08 10:02 ` [tip:core/iommu] irq_remap: Fix UP build failure tip-bot for Suresh Siddha
2012-05-08 7:08 ` [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning Suresh Siddha
2012-05-08 9:15 ` Ingo Molnar
2012-05-08 10:03 ` [tip:core/iommu] irq_remap: Fix " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339102584.28766.94.camel@sbsiddha-desk.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®