mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: target-devel <target-devel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] target fixes for v3.4-rc7
Date: Fri, 11 May 2012 14:58:54 -0700	[thread overview]
Message-ID: <1336773534.25759.170.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <1336773136.25759.167.camel@haakon2.linux-iscsi.org>

On Fri, 2012-05-11 at 14:52 -0700, Nicholas A. Bellinger wrote:
> Hi Linus !
> 
> This time around for -rc7, there is only a single outstanding target
> pending bugfix ready to be merged..
> 
> Please go ahead and pull from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git 3.4-urgent
> 
> This patch removes some incorrect legacy code to free se_lun_acl memory
> in the NodeACL release path that could potentially trigger an OOPs
> during shutdown once dynamic -> explicit initiator NodeACL conversion
> has occurred.
> 
> That said, we've been able to trigger an OOPs in v4.0 code for this
> special case when the associated MappedLUNs had not also been made
> explicit based on active TPG LUN layout during the conversion, so it
> really makes senses to go ahead and drop this extra cruft to avoid any
> possible issues here.
> 
> This ends up only effecting iscsi-target module code (it's the only
> user) and is CC'ed to stable.
> 
> Thanks!
> 
> --nab
> 
> Nicholas Bellinger (1):
>   target: Drop incorrect se_lun_acl release for dynamic -> explict ACL
>     conversion
> 
>  drivers/target/target_core_tpg.c |   21 ---------------------
>  1 files changed, 0 insertions(+), 21 deletions(-)
> 

Whoops sorry, missed the now unused variables in this patch..

Here is the updated diff-stat for target-pending/3.4-urgent

 drivers/target/target_core_tpg.c |   22 ----------------------
 1 files changed, 0 insertions(+), 22 deletions(-)

Thanks,

--nab



      reply	other threads:[~2012-05-11 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 21:52 Nicholas A. Bellinger
2012-05-11 21:58 ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336773534.25759.170.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®