mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] mfd: wm8400: Don't support non-modular build
@ 2012-05-14  9:13 Mark Brown
  2012-05-14  9:13 ` [PATCH 2/2] mfd: wm8400: Export wm8400_block_read() Mark Brown
  2012-05-14 20:21 ` [PATCH 1/2] mfd: wm8400: Don't support non-modular build Samuel Ortiz
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2012-05-14  9:13 UTC (permalink / raw)
  To: Stephen Rothwell, Samuel Ortiz; +Cc: linux-kernel, patches, Mark Brown

It's relying on non-exported symbols.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 8a767a6..0ff6d54 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -468,7 +468,7 @@ config MFD_S5M_CORE
 	 of the device
 
 config MFD_WM8400
-	tristate "Support Wolfson Microelectronics WM8400"
+	bool "Support Wolfson Microelectronics WM8400"
 	select MFD_CORE
 	depends on I2C
 	select REGMAP_I2C
-- 
1.7.10


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] mfd: wm8400: Export wm8400_block_read()
  2012-05-14  9:13 [PATCH 1/2] mfd: wm8400: Don't support non-modular build Mark Brown
@ 2012-05-14  9:13 ` Mark Brown
  2012-05-14 20:21 ` [PATCH 1/2] mfd: wm8400: Don't support non-modular build Samuel Ortiz
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-05-14  9:13 UTC (permalink / raw)
  To: Stephen Rothwell, Samuel Ortiz; +Cc: linux-kernel, patches, Mark Brown

Used by the regulator driver.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/mfd/wm8400-core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c
index 9083b77..4b7d378 100644
--- a/drivers/mfd/wm8400-core.c
+++ b/drivers/mfd/wm8400-core.c
@@ -60,6 +60,7 @@ int wm8400_block_read(struct wm8400 *wm8400, u8 reg, int count, u16 *data)
 {
 	return regmap_bulk_read(wm8400->regmap, reg, data, count);
 }
+EXPORT_SYMBOL_GPL(wm8400_block_read);
 
 static int wm8400_register_codec(struct wm8400 *wm8400)
 {
-- 
1.7.10


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] mfd: wm8400: Don't support non-modular build
  2012-05-14  9:13 [PATCH 1/2] mfd: wm8400: Don't support non-modular build Mark Brown
  2012-05-14  9:13 ` [PATCH 2/2] mfd: wm8400: Export wm8400_block_read() Mark Brown
@ 2012-05-14 20:21 ` Samuel Ortiz
  1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-05-14 20:21 UTC (permalink / raw)
  To: Mark Brown; +Cc: Stephen Rothwell, linux-kernel, patches

Hi Mark,

On Mon, May 14, 2012 at 10:13:15AM +0100, Mark Brown wrote:
> It's relying on non-exported symbols.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Both patches applied, thanks a lot.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-14 20:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-14  9:13 [PATCH 1/2] mfd: wm8400: Don't support non-modular build Mark Brown
2012-05-14  9:13 ` [PATCH 2/2] mfd: wm8400: Export wm8400_block_read() Mark Brown
2012-05-14 20:21 ` [PATCH 1/2] mfd: wm8400: Don't support non-modular build Samuel Ortiz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®