From: Joe Perches <joe@perches.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Kan Liang <kan.liang@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>, Shawn Landden <shawn@git.icu>,
Nathan Chancellor <natechancellor@gmail.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Chandler Carruth <chandlerc@google.com>
Subject: Re: [PATCH] perf/x86/intel: Mark expected switch fall-throughs
Date: Tue, 25 Jun 2019 15:29:27 -0700 [thread overview]
Message-ID: <1336988f46fb7ffda925ab86a6e4d5437cfdb275.camel@perches.com> (raw)
In-Reply-To: <CAKwvOdn5j8Hkc_jrLMbhg-4jbNya+agtMJi=c9o01RPCno1Q+w@mail.gmail.com>
On Tue, 2019-06-25 at 11:15 -0700, Nick Desaulniers wrote:
> Unreleased versions of Clang built from source can; the latest release
> of Clang-8 doesn't have asm goto support required for
> CONFIG_JUMP_LABEL. Things can get complicated based on which kernel
> tree/branch (mainline, -next, stable), arch, and configs, but I think
> we just have a few long tail bugs left.
At some point, when clang generically compiles the kernel,
I believe it'd be good to remove the various bits that
are unusual like CONFIG_CC_HAS_ASM_GOTO in Makefile
and the scripts/clang-version.sh and the like.
This could help when compiling a specific .config on
different systems.
Maybe add the equivalent compiler-gcc.h #define below
even before the removals
(whatever minor/patchlevel appropriate)
---
include/linux/compiler-clang.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
index 333a6695a918..b46aece0f9ca 100644
--- a/include/linux/compiler-clang.h
+++ b/include/linux/compiler-clang.h
@@ -5,6 +5,14 @@
/* Compiler specific definitions for Clang compiler */
+#define CLANG_VERSION (__clang_major__ * 10000 \
+ + __clang_minor__ * 100 \
+ + __clang_patchlevel__)
+
+#if CLANG_VERSION < 90000
+# error Sorry, your compiler is too old - please upgrade it.
+#endif
+
#define uninitialized_var(x) x = *(&(x))
/* same as gcc, this was present in clang-2.6 so we can assume it works
next prev parent reply other threads:[~2019-06-25 22:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 16:19 Gustavo A. R. Silva
2019-06-24 19:31 ` Peter Zijlstra
2019-06-24 19:45 ` Joe Perches
2019-06-24 20:37 ` Peter Zijlstra
2019-06-24 20:53 ` Gustavo A. R. Silva
2019-06-24 20:57 ` Joe Perches
2019-06-25 7:20 ` Peter Zijlstra
2019-06-24 22:28 ` Miguel Ojeda
2019-06-25 7:18 ` Peter Zijlstra
2019-06-25 12:47 ` Miguel Ojeda
2019-06-25 18:15 ` Nick Desaulniers
2019-06-25 22:29 ` Joe Perches [this message]
2019-06-25 22:57 ` Nick Desaulniers
2019-06-25 23:25 ` Joe Perches
2019-06-26 8:49 ` Peter Zijlstra
2019-06-26 22:14 ` Nick Desaulniers
2019-06-27 7:12 ` Peter Zijlstra
2019-06-28 13:31 ` Peter Zijlstra
2019-06-28 18:44 ` Nick Desaulniers
2019-06-29 7:10 ` Peter Zijlstra
2019-06-25 17:12 ` Kees Cook
2019-06-25 18:05 ` Nathan Chancellor
2019-06-25 19:53 ` Thomas Gleixner
2019-06-25 20:27 ` Nathan Chancellor
2019-06-25 20:37 ` Nick Desaulniers
2019-06-25 21:47 ` Thomas Gleixner
2019-06-26 5:10 ` Nathan Chancellor
2019-06-26 15:18 ` Thomas Gleixner
2019-06-26 19:00 ` Nathan Chancellor
2019-06-26 19:46 ` Thomas Gleixner
2019-06-26 20:03 ` Nathan Chancellor
2019-06-26 9:24 ` Peter Zijlstra
2019-06-26 9:55 ` Peter Zijlstra
2019-06-26 22:23 ` Nick Desaulniers
2019-06-27 7:35 ` Peter Zijlstra
2019-06-26 10:43 ` Peter Zijlstra
2019-06-26 22:15 ` Nick Desaulniers
2019-06-27 7:16 ` Peter Zijlstra
2019-06-26 16:30 ` Peter Zijlstra
2019-06-26 22:33 ` Nick Desaulniers
2019-06-26 23:11 ` Thomas Gleixner
2019-06-27 7:11 ` Peter Zijlstra
2019-06-25 23:46 ` Arnaldo Carvalho de Melo
2019-06-26 5:14 ` Nathan Chancellor
2019-06-25 20:09 ` Kees Cook
2019-06-26 8:06 ` Peter Zijlstra
2019-06-25 7:15 ` Peter Zijlstra
2019-07-25 16:27 ` [tip:perf/urgent] " tip-bot for Gustavo A. R. Silva
2019-07-25 17:06 ` Borislav Petkov
2019-07-25 17:35 ` Peter Zijlstra
2019-07-25 23:18 ` Joe Perches
2019-07-25 23:28 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336988f46fb7ffda925ab86a6e4d5437cfdb275.camel@perches.com \
--to=joe@perches.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=chandlerc@google.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=shawn@git.icu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®