From: Phil Carmody <ext-phil.2.carmody@nokia.com>
To: apw@canonical.com
Cc: linux-kernel@vger.kernel.org, ext-phil.2.carmody@nokia.com
Subject: [PATCH 1/1] checkpatch: don't fake typedefs with #define
Date: Thu, 17 May 2012 15:52:12 +0300 [thread overview]
Message-ID: <1337259132-28774-1-git-send-email-ext-phil.2.carmody@nokia.com> (raw)
People seemed to be taking the "no typedefs" rule too literally,
and were using #define to abide by the letter rather than the
spirit of the law. E.g. #define FOO_t struct _FOO_t
Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
---
scripts/checkpatch.pl | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index faea0ec..7dc41c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2299,6 +2299,12 @@ sub process {
"do not add new typedefs\n" . $herecurr);
}
+# check for deliberate avoidance of the above anti-typedef rule
+ if ($line =~ /#\s*define\s+$Ident\s+$Type\b/) {
+ WARN("NEW_TYPEDEFS",
+ "do not fake typedefs using #define\n" . $herecurr);
+ }
+
# * goes on variable not on type
# (char*[ const])
while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
--
1.7.2.5
next reply other threads:[~2012-05-17 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 12:52 Phil Carmody [this message]
2012-05-17 20:54 ` Joe Perches
2012-05-17 21:16 ` Phil Carmody
2012-05-17 21:24 ` Joe Perches
2012-05-21 12:05 ` Phil Carmody
2012-05-21 16:41 ` Joe Perches
2012-05-22 8:01 ` Phil Carmody
2012-05-22 16:48 ` Joe Perches
2012-05-23 1:54 ` Ryan Mallon
2012-05-23 2:02 ` Joe Perches
2012-05-23 2:50 ` Ryan Mallon
2012-05-23 3:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337259132-28774-1-git-send-email-ext-phil.2.carmody@nokia.com \
--to=ext-phil.2.carmody@nokia.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®