From: Joe Perches <joe@perches.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: linux-kernel@vger.kernel.org, apw@canonical.com
Subject: Re: [PATCH 1/1] checkpatch: don't fake typedefs with #define
Date: Thu, 17 May 2012 14:24:57 -0700 [thread overview]
Message-ID: <1337289897.8872.8.camel@joe2Laptop> (raw)
In-Reply-To: <20120517211641.GC27953@pcarmody2.research.nokia.com>
On Fri, 2012-05-18 at 00:16 +0300, Phil Carmody wrote:
> On 17/05/12 13:54 -0700, ext Joe Perches wrote:
> > > +# check for deliberate avoidance of the above anti-typedef rule
> > > + if ($line =~ /#\s*define\s+$Ident\s+$Type\b/) {
> > > + WARN("NEW_TYPEDEFS",
> > > + "do not fake typedefs using #define\n" . $herecurr);
> > > + }
> > > +
> >
> > I think the false positive rate is pretty high.
> > I used this and don't see too many I'd remove.
> >
> > $ git grep -E "#\s*define\s+\w+\s+(struct|unsigned|char|short|int|long|const)\b"
> >
> > Got an example you want this to find?
>
> Too many. Alas I can't share them.
Too bad.
If all the defines end in _t maybe you could use
if ($line =~ /^\+\s*#\s*define\s+\w+_t\s+$Type\b/) {
etc...
next prev parent reply other threads:[~2012-05-17 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 12:52 Phil Carmody
2012-05-17 20:54 ` Joe Perches
2012-05-17 21:16 ` Phil Carmody
2012-05-17 21:24 ` Joe Perches [this message]
2012-05-21 12:05 ` Phil Carmody
2012-05-21 16:41 ` Joe Perches
2012-05-22 8:01 ` Phil Carmody
2012-05-22 16:48 ` Joe Perches
2012-05-23 1:54 ` Ryan Mallon
2012-05-23 2:02 ` Joe Perches
2012-05-23 2:50 ` Ryan Mallon
2012-05-23 3:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337289897.8872.8.camel@joe2Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®