From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>, Kay Sievers <kay@vrfy.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PATCH] driver core patches for 3.5-rc1 - try 2
Date: Tue, 22 May 2012 15:01:58 -0700 [thread overview]
Message-ID: <1337724118.11918.2.camel@joe2Laptop> (raw)
(resending cc'ing lkml)
(Also, apologies about no in-reply-to, lkml.org is down)
While there are several things I like about the
printk modifications, (binary header, delta time,
slightly better partial message deinterleaving,
global msg_id, kmsg is ok too), I am concerned
about the utility and expectations for the new
[v]printk_emit functions.
I think it is not really ready to be merged
at this time.
The commit sequencing was unclean.
The original commit originally required KERN_CONT
and it was modified by another commit to return
to the current behavior.
What really are the expectations and true use-cases
for [v]printk_emit?
How is it really better that what is available now?
Perhaps it would be better to respin all the
printk modifications without adding [v]printk_emit
and have the [v]printk_emit bits debated a bit more.
next reply other threads:[~2012-05-22 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 22:01 Joe Perches [this message]
[not found] <1337723927.9270.15.camel@joe2Laptop>
2012-05-22 22:08 ` Greg KH
[not found] ` <20120522220534.GC12705@kroah.com>
2012-05-22 22:12 ` Joe Perches
2012-05-23 6:12 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-05-22 15:14 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337724118.11918.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®