From: Steven Rostedt <rostedt@goodmis.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <mhiramat@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use test_and_clear_bit() instead atomic_dec_and_test() for stop_machine
Date: Wed, 23 May 2012 04:43:23 -0400 [thread overview]
Message-ID: <1337762603.13348.139.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <87mx4zr0l9.fsf@devron.myhome.or.jp>
On Wed, 2012-05-23 at 13:19 +0900, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
>
> stop_machine_first is just to see if it is first one or not. In this
> usage, atomic_dec_and_test() makes value less than 0.
>
> I think it is not desirable, because it only triggers
> atomic_dec_and_test() less than 0 debug patch. (the patch tests result
> of atomic_dec_and_test() is < 0)
>
> So, this uses atomic_xchg() instead.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
>
> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-05-23 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87likkt7u6.fsf@devron.myhome.or.jp>
2012-05-22 18:11 ` OGAWA Hirofumi
2012-05-22 21:46 ` Steven Rostedt
2012-05-23 2:44 ` OGAWA Hirofumi
2012-05-23 4:19 ` OGAWA Hirofumi
2012-05-23 8:43 ` Steven Rostedt [this message]
2012-06-07 12:54 ` Steven Rostedt
2012-06-07 13:18 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337762603.13348.139.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®