mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Use test_and_clear_bit() instead atomic_dec_and_test() for stop_machine
Date: Thu, 07 Jun 2012 22:18:08 +0900	[thread overview]
Message-ID: <877gvji7lb.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1339073661.7559.1.camel@gandalf.stny.rr.com> (Steven Rostedt's message of "Thu, 07 Jun 2012 08:54:21 -0400")

Steven Rostedt <rostedt@goodmis.org> writes:

> On Wed, 2012-05-23 at 13:19 +0900, OGAWA Hirofumi wrote:
>> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>> 
>> >> The down side to this is that it adds 4 more bytes on a 64bit
>> >> machine. (sizeof(unsigned log) == 8 and sizeof(atomic_t) == 4)
>> 
>> Another patch without additional 4bytes. This simply change
>> atomic_dec_and_test() to atomic_xchg().
>> 
>
> If nobody picked this up, you might want to resend it with my acked-by.
> (The second patch, not the first). As patches added to replies are
> usually ignored.

Thanks. I was going to add that to my personal patchset, I will try it again.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      reply	other threads:[~2012-06-07 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87likkt7u6.fsf@devron.myhome.or.jp>
2012-05-22 18:11 ` OGAWA Hirofumi
2012-05-22 21:46   ` Steven Rostedt
2012-05-23  2:44     ` OGAWA Hirofumi
2012-05-23  4:19       ` OGAWA Hirofumi
2012-05-23  8:43         ` Steven Rostedt
2012-06-07 12:54         ` Steven Rostedt
2012-06-07 13:18           ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gvji7lb.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome