mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regmap: Use select .. if to get IRQ_DOMAIN enabled
@ 2012-05-23  9:31 Mark Brown
  2012-05-24  1:06 ` David Rientjes
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-05-23  9:31 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown

Ensure that we can't get randconfig breakage by doing the IRQ_DOMAIN
select automatically. Don't just do the select from REGMAP_IRQ to ensure
that the select actually gets noticed.

Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/base/regmap/Kconfig |    1 +
 drivers/mfd/Kconfig         |    3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index 9ef0a53..6be390b 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -6,6 +6,7 @@ config REGMAP
 	default y if (REGMAP_I2C || REGMAP_SPI)
 	select LZO_COMPRESS
 	select LZO_DECOMPRESS
+	select IRQ_DOMAIN if REGMAP_IRQ
 	bool
 
 config REGMAP_I2C
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e35cb6b..213304d 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -376,7 +376,6 @@ config PMIC_DA9052
 
 config MFD_DA9052_SPI
 	bool "Support Dialog Semiconductor DA9052/53 PMIC variants with SPI"
-	select IRQ_DOMAIN
 	select REGMAP_SPI
 	select REGMAP_IRQ
 	select PMIC_DA9052
@@ -389,7 +388,6 @@ config MFD_DA9052_SPI
 
 config MFD_DA9052_I2C
 	bool "Support Dialog Semiconductor DA9052/53 PMIC variants with I2C"
-	select IRQ_DOMAIN
 	select REGMAP_I2C
 	select REGMAP_IRQ
 	select PMIC_DA9052
@@ -560,7 +558,6 @@ config MFD_WM8994
 	bool "Support Wolfson Microelectronics WM8994"
 	select MFD_CORE
 	select REGMAP_I2C
-	select IRQ_DOMAIN
 	select REGMAP_IRQ
 	depends on I2C=y && GENERIC_HARDIRQS
 	help
-- 
1.7.10


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regmap: Use select .. if to get IRQ_DOMAIN enabled
  2012-05-23  9:31 [PATCH] regmap: Use select .. if to get IRQ_DOMAIN enabled Mark Brown
@ 2012-05-24  1:06 ` David Rientjes
  0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2012-05-24  1:06 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-kernel

On Wed, 23 May 2012, Mark Brown wrote:

> Ensure that we can't get randconfig breakage by doing the IRQ_DOMAIN
> select automatically. Don't just do the select from REGMAP_IRQ to ensure
> that the select actually gets noticed.
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/base/regmap/Kconfig |    1 +
>  drivers/mfd/Kconfig         |    3 ---
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 9ef0a53..6be390b 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -6,6 +6,7 @@ config REGMAP
>  	default y if (REGMAP_I2C || REGMAP_SPI)
>  	select LZO_COMPRESS
>  	select LZO_DECOMPRESS
> +	select IRQ_DOMAIN if REGMAP_IRQ
>  	bool
>  
>  config REGMAP_I2C

Just do the "select IRQ_DOMAIN" for REGMAP_IRQ like I did it in my patch 
and stop dropping cc's.  Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-24  1:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-23  9:31 [PATCH] regmap: Use select .. if to get IRQ_DOMAIN enabled Mark Brown
2012-05-24  1:06 ` David Rientjes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®