From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, frank.arnold@amd.com,
torvalds@linux-foundation.org, tglx@linutronix.de,
borislav.petkov@amd.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mce] x86/mce: Fix 32-bit build
Date: Wed, 23 May 2012 18:18:18 +0200 [thread overview]
Message-ID: <1337789898.9783.19.camel@laptop> (raw)
In-Reply-To: <tip-80f033610fb968e75f5d470233d8d0260d7a72ed@git.kernel.org>
On Wed, 2012-05-23 at 09:08 -0700, tip-bot for Borislav Petkov wrote:
> + if (val & BIT_64(62)) {
> + val &= ~BIT_64(62);
> + wrmsrl(msrs[i], val);
> }
Wouldn't it be much better to name those things, BIT(62), BIT(18) etc.
aren't very descriptive at all.
MCE_MISC_COUNTER_PRESENT is much more descriptive than BIT(62).
next prev parent reply other threads:[~2012-05-23 16:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 10:53 [PATCH 1/2] x86, bitops: Move BIT_64 for a wider use Borislav Petkov
2012-05-22 10:53 ` [PATCH 2/2] x86, MCE: Fix 32-bit build Borislav Petkov
2012-05-23 16:08 ` [tip:x86/mce] x86/mce: " tip-bot for Borislav Petkov
2012-05-23 16:18 ` Peter Zijlstra [this message]
2012-05-23 16:23 ` Borislav Petkov
2012-05-23 16:31 ` Peter Zijlstra
2012-05-23 16:44 ` Borislav Petkov
2012-05-23 16:46 ` Peter Zijlstra
2012-05-23 16:54 ` Borislav Petkov
2012-05-23 16:07 ` [tip:x86/mce] x86/bitops: Move BIT_64() for a wider use tip-bot for Borislav Petkov
2012-05-23 16:10 ` Peter Zijlstra
2012-05-23 16:11 ` H. Peter Anvin
2012-05-23 16:19 ` Borislav Petkov
2012-05-23 16:29 ` Peter Zijlstra
2012-05-23 16:31 ` H. Peter Anvin
2012-05-23 16:43 ` Linus Torvalds
2012-05-23 16:47 ` H. Peter Anvin
2012-05-23 16:50 ` H. Peter Anvin
2012-05-23 16:54 ` Linus Torvalds
2012-05-23 16:55 ` H. Peter Anvin
2012-05-23 16:53 ` Borislav Petkov
2012-05-23 16:57 ` Linus Torvalds
2012-05-23 17:11 ` Borislav Petkov
2012-05-23 17:37 ` Linus Torvalds
2012-05-23 16:54 ` Peter Zijlstra
2012-05-23 16:40 ` Linus Torvalds
2012-05-23 16:42 ` H. Peter Anvin
2012-05-23 16:45 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337789898.9783.19.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=frank.arnold@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome