mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
	paulus@samba.org, cjashfor@linux.vnet.ibm.com,
	fweisbec@gmail.com
Cc: eranian@google.com, gorcunov@openvz.org, tzanussi@gmail.com,
	mhiramat@redhat.com, robert.richter@amd.com, fche@redhat.com,
	linux-kernel@vger.kernel.org, masami.hiramatsu.pt@hitachi.com,
	drepper@gmail.com, asharma@fb.com,
	benjamin.redelings@nescent.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 05/16] perf: Add attribute to filter out user callchains
Date: Wed, 23 May 2012 21:32:04 +0200	[thread overview]
Message-ID: <1337801535-12865-6-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1337801535-12865-1-git-send-email-jolsa@redhat.com>

Add the new exclude_user_callchain attribute to filter out
frame pointer based user callchains.

This is something we want to select when we use the dwarf cfi
callchain mode, because frame pointer based user callchains are
useless in this mode.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 include/linux/perf_event.h |    4 +++-
 kernel/events/callchain.c  |    4 ++--
 kernel/events/core.c       |    3 ++-
 kernel/events/internal.h   |    3 ++-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index dcdc97e..df6ba37 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -275,7 +275,9 @@ struct perf_event_attr {
 				exclude_host   :  1, /* don't count in host   */
 				exclude_guest  :  1, /* don't count in guest  */
 
-				__reserved_1   : 43;
+				exclude_user_callchain : 1, /* only record kernel callchains */
+
+				__reserved_1   : 42;
 
 	union {
 		__u32		wakeup_events;	  /* wakeup every n events */
diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index 6581a04..884e997 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -153,7 +153,7 @@ put_callchain_entry(int rctx)
 	put_recursion_context(__get_cpu_var(callchain_recursion), rctx);
 }
 
-struct perf_callchain_entry *perf_callchain(struct pt_regs *regs)
+struct perf_callchain_entry *perf_callchain(struct pt_regs *regs, int user)
 {
 	int rctx;
 	struct perf_callchain_entry *entry;
@@ -177,7 +177,7 @@ struct perf_callchain_entry *perf_callchain(struct pt_regs *regs)
 			regs = NULL;
 	}
 
-	if (regs) {
+	if (user && regs) {
 		perf_callchain_store(entry, PERF_CONTEXT_USER);
 		perf_callchain_user(entry, regs);
 	}
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 0ace2c7..8e73a2b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4138,8 +4138,9 @@ void perf_prepare_sample(struct perf_event_header *header,
 
 	if (sample_type & PERF_SAMPLE_CALLCHAIN) {
 		int size = 1;
+		int user = !event->attr.exclude_user_callchain;
 
-		data->callchain = perf_callchain(regs);
+		data->callchain = perf_callchain(regs, user);
 
 		if (data->callchain)
 			size += data->callchain->nr;
diff --git a/kernel/events/internal.h b/kernel/events/internal.h
index ed8ab26..b18465b 100644
--- a/kernel/events/internal.h
+++ b/kernel/events/internal.h
@@ -121,7 +121,8 @@ DEFINE_OUTPUT_COPY(__output_copy, memcpy_common)
 DEFINE_OUTPUT_COPY(__output_copy_user, arch_perf_out_copy_user)
 
 /* Callchain handling */
-extern struct perf_callchain_entry *perf_callchain(struct pt_regs *regs);
+extern struct perf_callchain_entry *perf_callchain(struct pt_regs *regs,
+						   int user);
 extern int get_callchain_buffers(void);
 extern void put_callchain_buffers(void);
 
-- 
1.7.7.6


  parent reply	other threads:[~2012-05-23 19:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 19:31 [RFCv4 00/16] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-05-23 19:32 ` [PATCH 01/16] perf: Unified API to record selective sets of arch registers Jiri Olsa
2012-05-24  9:33   ` Peter Zijlstra
2012-05-24 12:13     ` Stephane Eranian
2012-05-24 12:37       ` Jiri Olsa
2012-05-24  9:43   ` Peter Zijlstra
2012-06-07  9:46     ` Frederic Weisbecker
2012-06-07 10:29       ` Peter Zijlstra
2012-06-07 10:31         ` Frederic Weisbecker
2012-06-07 10:36         ` Stephane Eranian
2012-05-23 19:32 ` [PATCH 02/16] perf: Add ability to attach registers dump to sample Jiri Olsa
2012-05-24  9:50   ` Peter Zijlstra
2012-05-24 10:06     ` Stephane Eranian
2012-05-24 10:42       ` Peter Zijlstra
2012-05-24 11:52         ` Jiri Olsa
2012-05-25 10:01           ` Peter Zijlstra
2012-06-07  9:56           ` Frederic Weisbecker
2012-05-24  9:51   ` Peter Zijlstra
2012-05-24  9:57   ` Peter Zijlstra
2012-05-23 19:32 ` [PATCH 03/16] perf: Factor __output_copy to be usable with specific copy function Jiri Olsa
2012-05-23 19:32 ` [PATCH 04/16] perf: Add ability to attach user stack dump to sample Jiri Olsa
2012-05-24 10:44   ` Peter Zijlstra
2012-05-24 10:51   ` Peter Zijlstra
2012-05-24 12:16     ` Jiri Olsa
2012-06-07 10:07     ` Frederic Weisbecker
2012-06-07 14:07       ` Jiri Olsa
2012-05-23 19:32 ` Jiri Olsa [this message]
2012-05-24 10:57   ` [PATCH 05/16] perf: Add attribute to filter out user callchains Peter Zijlstra
2012-05-23 19:32 ` [PATCH 06/16] perf, tool: Factor DSO symtab types to generic binary types Jiri Olsa
2012-05-23 19:32 ` [PATCH 07/16] perf, tool: Add interface to read DSO image data Jiri Olsa
2012-05-23 19:32 ` [PATCH 08/16] perf, tool: Add '.note' check into search for NOTE section Jiri Olsa
2012-05-23 19:32 ` [PATCH 09/16] perf, tool: Back [vdso] DSO with real data Jiri Olsa
2012-05-23 19:32 ` [PATCH 10/16] perf, tool: Add interface to arch registers sets Jiri Olsa
2012-05-23 19:32 ` [PATCH 11/16] perf, tool: Add libunwind dependency for dwarf cfi unwinding Jiri Olsa
2012-05-23 19:32 ` [PATCH 12/16] perf, tool: Support user regs and stack in sample parsing Jiri Olsa
2012-05-23 19:32 ` [PATCH 13/16] perf, tool: Support for dwarf cfi unwinding on post processing Jiri Olsa
2012-05-23 19:32 ` [PATCH 14/16] perf, tool: Support for dwarf mode callchain on perf record Jiri Olsa
2012-05-23 19:32 ` [PATCH 15/16] perf, tool: Add dso data caching Jiri Olsa
2012-05-23 19:32 ` [PATCH 16/16] perf, tool: Add dso data caching tests Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2012-04-17 11:17 [RFCv2 00/15] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-04-17 11:17 ` [PATCH 05/16] perf: Add attribute to filter out user callchains Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337801535-12865-6-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=asharma@fb.com \
    --cc=benjamin.redelings@nescent.org \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=drepper@gmail.com \
    --cc=eranian@google.com \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=robert.richter@amd.com \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome