From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com
Cc: eranian@google.com, gorcunov@openvz.org, tzanussi@gmail.com,
mhiramat@redhat.com, robert.richter@amd.com, fche@redhat.com,
linux-kernel@vger.kernel.org, masami.hiramatsu.pt@hitachi.com,
drepper@gmail.com, asharma@fb.com,
benjamin.redelings@nescent.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 08/16] perf, tool: Add '.note' check into search for NOTE section
Date: Wed, 23 May 2012 21:32:07 +0200 [thread overview]
Message-ID: <1337801535-12865-9-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1337801535-12865-1-git-send-email-jolsa@redhat.com>
Adding '.note' section name to be check when looking for notes
section. The '.note' name is used by kernel VDSO.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/util/symbol.c | 29 +++++++++++++++++++++++------
1 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 041ffa5..6955c3c 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1472,14 +1472,31 @@ static int elf_read_build_id(Elf *elf, void *bf, size_t size)
goto out;
}
- sec = elf_section_by_name(elf, &ehdr, &shdr,
- ".note.gnu.build-id", NULL);
- if (sec == NULL) {
+ /*
+ * Check following sections for notes:
+ * '.note.gnu.build-id'
+ * '.notes'
+ * '.note' (VDSO specific)
+ */
+ do {
+ sec = elf_section_by_name(elf, &ehdr, &shdr,
+ ".note.gnu.build-id", NULL);
+ if (sec)
+ break;
+
sec = elf_section_by_name(elf, &ehdr, &shdr,
".notes", NULL);
- if (sec == NULL)
- goto out;
- }
+ if (sec)
+ break;
+
+ sec = elf_section_by_name(elf, &ehdr, &shdr,
+ ".note", NULL);
+ if (sec)
+ break;
+
+ return err;
+
+ } while (0);
data = elf_getdata(sec, NULL);
if (data == NULL)
--
1.7.7.6
next prev parent reply other threads:[~2012-05-23 19:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 19:31 [RFCv4 00/16] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-05-23 19:32 ` [PATCH 01/16] perf: Unified API to record selective sets of arch registers Jiri Olsa
2012-05-24 9:33 ` Peter Zijlstra
2012-05-24 12:13 ` Stephane Eranian
2012-05-24 12:37 ` Jiri Olsa
2012-05-24 9:43 ` Peter Zijlstra
2012-06-07 9:46 ` Frederic Weisbecker
2012-06-07 10:29 ` Peter Zijlstra
2012-06-07 10:31 ` Frederic Weisbecker
2012-06-07 10:36 ` Stephane Eranian
2012-05-23 19:32 ` [PATCH 02/16] perf: Add ability to attach registers dump to sample Jiri Olsa
2012-05-24 9:50 ` Peter Zijlstra
2012-05-24 10:06 ` Stephane Eranian
2012-05-24 10:42 ` Peter Zijlstra
2012-05-24 11:52 ` Jiri Olsa
2012-05-25 10:01 ` Peter Zijlstra
2012-06-07 9:56 ` Frederic Weisbecker
2012-05-24 9:51 ` Peter Zijlstra
2012-05-24 9:57 ` Peter Zijlstra
2012-05-23 19:32 ` [PATCH 03/16] perf: Factor __output_copy to be usable with specific copy function Jiri Olsa
2012-05-23 19:32 ` [PATCH 04/16] perf: Add ability to attach user stack dump to sample Jiri Olsa
2012-05-24 10:44 ` Peter Zijlstra
2012-05-24 10:51 ` Peter Zijlstra
2012-05-24 12:16 ` Jiri Olsa
2012-06-07 10:07 ` Frederic Weisbecker
2012-06-07 14:07 ` Jiri Olsa
2012-05-23 19:32 ` [PATCH 05/16] perf: Add attribute to filter out user callchains Jiri Olsa
2012-05-24 10:57 ` Peter Zijlstra
2012-05-23 19:32 ` [PATCH 06/16] perf, tool: Factor DSO symtab types to generic binary types Jiri Olsa
2012-05-23 19:32 ` [PATCH 07/16] perf, tool: Add interface to read DSO image data Jiri Olsa
2012-05-23 19:32 ` Jiri Olsa [this message]
2012-05-23 19:32 ` [PATCH 09/16] perf, tool: Back [vdso] DSO with real data Jiri Olsa
2012-05-23 19:32 ` [PATCH 10/16] perf, tool: Add interface to arch registers sets Jiri Olsa
2012-05-23 19:32 ` [PATCH 11/16] perf, tool: Add libunwind dependency for dwarf cfi unwinding Jiri Olsa
2012-05-23 19:32 ` [PATCH 12/16] perf, tool: Support user regs and stack in sample parsing Jiri Olsa
2012-05-23 19:32 ` [PATCH 13/16] perf, tool: Support for dwarf cfi unwinding on post processing Jiri Olsa
2012-05-23 19:32 ` [PATCH 14/16] perf, tool: Support for dwarf mode callchain on perf record Jiri Olsa
2012-05-23 19:32 ` [PATCH 15/16] perf, tool: Add dso data caching Jiri Olsa
2012-05-23 19:32 ` [PATCH 16/16] perf, tool: Add dso data caching tests Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 11:17 [RFCv2 00/15] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-04-17 11:17 ` [PATCH 08/16] perf, tool: Add '.note' check into search for NOTE section Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337801535-12865-9-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=asharma@fb.com \
--cc=benjamin.redelings@nescent.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=drepper@gmail.com \
--cc=eranian@google.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome